Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add capability to update existing secret #3551

Merged
merged 6 commits into from
Dec 14, 2024

Conversation

olavtar
Copy link
Contributor

@olavtar olavtar commented Dec 6, 2024

https://issues.redhat.com/browse/NVPE-77

Description

Added the ability to update the existing secret with the new API key.

How Has This Been Tested?

  • Tested by updating the secret.
  • Tested by removing the account and trying to update the secret.

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Dec 6, 2024
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.40%. Comparing base (c187244) to head (6736b32).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3551      +/-   ##
==========================================
- Coverage   85.55%   85.40%   -0.15%     
==========================================
  Files        1373     1378       +5     
  Lines       31195    31315     +120     
  Branches     8736     8761      +25     
==========================================
+ Hits        26689    26746      +57     
- Misses       4506     4569      +63     

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fdafba...6736b32. Read the comment docs.

@emilys314
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Dec 9, 2024
@emilys314
Copy link
Contributor

/lgtm

backend/src/routes/api/integrations/nim/index.ts Outdated Show resolved Hide resolved
Comment on lines 71 to 72
const { coreV1Api } = fastify.kube;
const { namespace } = fastify.kube;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, you should really put these in the same line

Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
… is created or retrieved

Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
Signed-off-by: Olga Lavtar <olavtar@redhat.com>
@emilys314
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 11, 2024
Copy link
Member

@andrewballantyne andrewballantyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is needed, please do it in a future PR.

Nothing else is wrong with this PR so I'm going to approve it; but it definitely could use with some wording update.

@@ -68,10 +64,9 @@ export const createNIMAccount = async (

export const createNIMSecret = async (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be named differently

Suggested change
export const createNIMSecret = async (
export const manageNIMSecret = async (

Or something else... it's not just creating it anymore. It's confusing to read the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, will update in the future PR. Thanks.

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d402803 into opendatahub-io:main Dec 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants