-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress e2e Test - Verify Switcher to Masterhead (enhanced to validate all relative application links) #3560
Cypress e2e Test - Verify Switcher to Masterhead (enhanced to validate all relative application links) #3560
Conversation
increase card timeout and delete active wait
…e/odh-dashboard into cypress-RHOAIENG-14368
…ttps://github.com/antowaddle/odh-dashboard into cypress-RHOAIENG-12649
…to cypress-RHOAIENG-15766
Skipping CI for Draft Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3560 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 1373 1373
Lines 31195 31195
Branches 8736 8736
=======================================
+ Hits 26686 26687 +1
+ Misses 4509 4508 -1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: FedeAlonso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…e all relative application links) (opendatahub-io#3560) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit for a new test * Fixed relative pathing issue --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
…e all relative application links) (opendatahub-io#3560) * Initial WIP version of resource creation test * Experimental changes to poll the UI for updates * Working version if resource is present * increase card timeout and delete active wait * Added changes to find namespace from variables * Final changes to read variables, cleaned up utils * Small change to a comment * Dummy change to trigger mocks * Save changes on cypress-RHOAIENG-12649 * Changed file directories and names as requested on a PR comment * Saving changes to current branch * Additional directory/file name changes * Additional changes to save * Resolving timeout issue breaking mock tests, also resolved latest PR comments * Further changes for this test * Changes to revert the exist method appended to getCardView. * Fixed linting * Linting fixes * Final comments added * Fixed merge conflict * Small change to page object name * dummy commit * Removed RHOAI bug workaround * Removed comments * Last comment change * Initial commit for a new test * Fixed relative pathing issue --------- Co-authored-by: Fede Alonso <fealonso@redhat.com>
https://issues.redhat.com/browse/RHOAIENG-15766
Description
Migrate ODS-771 to Cypress
How Has This Been Tested?
How to run?
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testApplicationLinks.cy.ts can be run.
Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dashboardNavigation/testApplicationLinks.cy.ts" --browser chrome
Test Impact
Request review criteria:
Self checklist (all need to be checked):
After the PR is posted & before it merges:
main