Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): add wait in deploy model test #3567

Merged

Conversation

gitdallas
Copy link
Contributor

fixes issue with a flakey deploy model test

Description

When switching projects in the deploy version modal of the UI, I notice there are new network calls and some changes on the UI. This may have caused the test to fail if the option to select didn't exist yet.

I added a wait on the network call for getting projects before attempting to select.

I also changed increased the timeout of finding the project name to select to 5 seconds.

How Has This Been Tested?

ran tests locally several times, passed

Test Impact

hopefully won't intermittently fail anymore

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
@openshift-ci openshift-ci bot requested review from Gkrumbach07 and ppadti December 11, 2024 20:13
@gitdallas gitdallas requested a review from mturley December 11, 2024 20:13
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (9124c70) to head (a2359fe).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3567      +/-   ##
==========================================
- Coverage   85.42%   85.19%   -0.23%     
==========================================
  Files        1378     1380       +2     
  Lines       31428    31536     +108     
  Branches     8797     8816      +19     
==========================================
+ Hits        26846    26866      +20     
- Misses       4582     4670      +88     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2b3d1...a2359fe. Read the comment docs.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 60ba3ee into opendatahub-io:main Dec 11, 2024
6 checks passed
ConorOM1 pushed a commit to ConorOM1/odh-dashboard that referenced this pull request Dec 12, 2024
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
ConorOM1 pushed a commit to ConorOM1/odh-dashboard that referenced this pull request Dec 12, 2024
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants