Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress e2e Test - Verify links in the Manifest Directory #3570

Merged

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Dec 12, 2024

https://issues.redhat.com/browse/RHOAIENG-9235
https://issues.redhat.com/browse/RHOAIENG-15765

Description

Migrate ODS-327, ODS-492 to Cypress.
Note - this issue also incorporates https://issues.redhat.com/browse/RHOAIENG-15765

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test

  • test-variables.yml should be configured properly

  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml

  • This test will currently fail as there are a number of issues (see linked issues https://issues.redhat.com/browse/RHOAIENG-9235) and these URLs have not been excluded.

  • As part of the validation process, I excluded the broken links raised in the linked issues of RHOAIENG-9235 and the test works fine.

image

Test Impact

  • None - this is a test

How to run

After exporting the test-variables.yml we have 2 different ways:

Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where verifyDSPCreation.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dashboardNavigation/testManifestLinks.cy.ts" --browser chrome

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

antowaddle and others added 30 commits November 20, 2024 17:07
increase card timeout and delete active wait
@antowaddle antowaddle changed the title Cypress rhoaieng 15765 Cypress e2e Test - Verify links in the Manifest Directory Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (5331d69) to head (e0ce260).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3570   +/-   ##
=======================================
  Coverage   85.19%   85.19%           
=======================================
  Files        1380     1380           
  Lines       31541    31541           
  Branches     8818     8818           
=======================================
+ Hits        26870    26872    +2     
+ Misses       4671     4669    -2     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5331d69...e0ce260. Read the comment docs.

@antowaddle antowaddle marked this pull request as ready for review December 12, 2024 17:20
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Dec 12, 2024
@openshift-ci openshift-ci bot requested review from dpanshug and lucferbux December 12, 2024 17:20
@FedeAlonso FedeAlonso self-requested a review December 12, 2024 22:32
@openshift-ci openshift-ci bot removed the lgtm label Dec 13, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 13, 2024
@FedeAlonso
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Dec 13, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 13, 2024
Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: FedeAlonso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4510b81 into opendatahub-io:main Dec 13, 2024
6 checks passed
@antowaddle antowaddle deleted the cypress-RHOAIENG-15765 branch December 20, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants