-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 'undeploy' in model registry (don't hide the Edit/Delete kebab when rendering deployments table in MR) #3571
Support 'undeploy' in model registry (don't hide the Edit/Delete kebab when rendering deployments table in MR) #3571
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can simplify this a bit
...rc/pages/modelRegistry/screens/ModelVersionDetails/ModelVersionRegisteredDeploymentsView.tsx
Outdated
Show resolved
Hide resolved
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @YuliaKrimerman
e0eb6af
to
2d5536a
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3571 +/- ##
==========================================
- Coverage 85.18% 85.17% -0.02%
==========================================
Files 1380 1380
Lines 31536 31535 -1
Branches 8816 8816
==========================================
- Hits 26864 26859 -5
- Misses 4672 4676 +4
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
https://issues.redhat.com/browse/RHOAIENG-16078
Description
I added the edit/Delete Kebab to the list of Version deployments
Screen.Recording.2024-12-12.at.9.17.36.AM.mov
How Has This Been Tested?
On K serve cluster, go to a model version Deployments tab and verify that we have the edit/Delete Kebab on each deployment
Test Impact
No test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main