Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'undeploy' in model registry (don't hide the Edit/Delete kebab when rendering deployments table in MR) #3571

Merged

Conversation

YuliaKrimerman
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-16078

Description

I added the edit/Delete Kebab to the list of Version deployments

Screen.Recording.2024-12-12.at.9.17.36.AM.mov

How Has This Been Tested?

On K serve cluster, go to a model version Deployments tab and verify that we have the edit/Delete Kebab on each deployment

Test Impact

No test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify this a bit

@YuliaKrimerman
Copy link
Contributor Author

/retest

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @YuliaKrimerman

@openshift-ci openshift-ci bot added the lgtm label Dec 12, 2024
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (60ba3ee) to head (2d5536a).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3571      +/-   ##
==========================================
- Coverage   85.18%   85.17%   -0.02%     
==========================================
  Files        1380     1380              
  Lines       31536    31535       -1     
  Branches     8816     8816              
==========================================
- Hits        26864    26859       -5     
- Misses       4672     4676       +4     
Files with missing lines Coverage Δ
...nDetails/ModelVersionRegisteredDeploymentsView.tsx 100.00% <ø> (ø)
...tend/src/pages/modelServing/screens/global/data.ts 73.17% <ø> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6016195...2d5536a. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 60cbae3 into opendatahub-io:main Dec 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants