Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support edit model registry after it's created #3572

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Dec 12, 2024

Closes: RHOAIENG-15879

Description

This PR aims to support edit model registry after it's created.

Screenshot 2024-12-12 at 9 48 09 PM

Loading state:

Screenshot 2024-12-12 at 9 48 36 PM

Error, when password fails to load:

Screenshot 2024-12-12 at 9 51 36 PM Screenshot 2024-12-12 at 10 08 02 PM

Resource name field

while creating MR:
Screenshot 2024-12-13 at 1 17 48 PM

Screenshot 2024-12-13 at 1 18 20 PM

while editing MR:

Screenshot 2024-12-13 at 1 18 36 PM

How Has This Been Tested?

  1. Go to model registry settings.
  2. Click on kebab action to see Edit model registry.

Test Impact

Added cypress test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti
Copy link
Contributor Author

ppadti commented Dec 12, 2024

@yih-wang could you please take a look at the screenshots?

@mturley
Copy link
Contributor

mturley commented Dec 12, 2024

@ppadti there's a merge conflict here now that #3555 is merged. For now we can ignore those new secure DB fields for prefilling/editing since the submit logic for them isn't implemented yet.

@yih-wang
Copy link

Oops sorry, I forgot to involve content review for the error message above...
@kaedward can you help take a look at the error message in this screen? This message will show up when the password is failed to be pulled from the OpenShift console because the source file in OpenShift is missing (been directly deleted in OpenShift, for example)
image

@yih-wang
Copy link

yih-wang commented Dec 13, 2024

Hey @ppadti , the screenshots look good, thank you! Can you add a screenshot to show how the first two fields look like?

@ppadti
Copy link
Contributor Author

ppadti commented Dec 13, 2024

Hey @ppadti , the screenshots look good, thank you! Can you add a screenshot to show how the first two fields look like?

@yih-wang sorry, I missed that. Updated the screen shoots.

@yih-wang
Copy link

Thank you @ppadti, looks good to me!

@ppadti ppadti force-pushed the RHOAIENG-15879 branch 2 times, most recently from 7b8b042 to d6a079a Compare December 13, 2024 09:59
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 84.26966% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (5331d69) to head (b421937).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...nd/src/pages/modelRegistrySettings/CreateModal.tsx 61.76% 13 Missing ⚠️
.../modelRegistrySettings/ModelRegistriesTableRow.tsx 92.30% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3572      +/-   ##
==========================================
+ Coverage   85.19%   85.23%   +0.04%     
==========================================
  Files        1380     1381       +1     
  Lines       31541    31592      +51     
  Branches     8818     8832      +14     
==========================================
+ Hits        26870    26927      +57     
+ Misses       4671     4665       -6     
Files with missing lines Coverage Δ
...ges/modelRegistrySettings/ModelRegistriesTable.tsx 100.00% <100.00%> (ø)
...RegistrySettings/ModelRegistryDatabasePassword.tsx 100.00% <100.00%> (+11.11%) ⬆️
...ntend/src/services/modelRegistrySettingsService.ts 63.04% <100.00%> (+6.52%) ⬆️
.../modelRegistrySettings/ModelRegistriesTableRow.tsx 95.65% <92.30%> (-0.78%) ⬇️
...nd/src/pages/modelRegistrySettings/CreateModal.tsx 85.18% <61.76%> (+15.39%) ⬆️

... and 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5331d69...b421937. Read the comment docs.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small code duplication nit, otherwise LGTM - although I'm having trouble testing it right now, see thread here

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! LGTM, thanks @ppadti.

Note: didn't test end to end, but the network request looks correct and we will verify end to end as part of the epic verification. Approving to unblock other stories.

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5d3efb2 into opendatahub-io:main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants