-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support edit model registry after it's created #3572
Support edit model registry after it's created #3572
Conversation
@yih-wang could you please take a look at the screenshots? |
Oops sorry, I forgot to involve content review for the error message above... |
Hey @ppadti , the screenshots look good, thank you! Can you add a screenshot to show how the first two fields look like? |
Thank you @ppadti, looks good to me! |
7b8b042
to
d6a079a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
==========================================
+ Coverage 85.19% 85.23% +0.04%
==========================================
Files 1380 1381 +1
Lines 31541 31592 +51
Branches 8818 8832 +14
==========================================
+ Hits 26870 26927 +57
+ Misses 4671 4665 -6
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small code duplication nit, otherwise LGTM - although I'm having trouble testing it right now, see thread here
frontend/src/pages/modelRegistrySettings/ModelRegistryDatabasePassword.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistrySettings/ModelRegistryDatabasePassword.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistrySettings/ModelRegistryDatabasePassword.tsx
Outdated
Show resolved
Hide resolved
d6a079a
to
b421937
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! LGTM, thanks @ppadti.
Note: didn't test end to end, but the network request looks correct and we will verify end to end as part of the epic verification. Approving to unblock other stories.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-15879
Description
This PR aims to support edit model registry after it's created.
Loading state:
Error, when password fails to load:
Resource name field
while creating MR:
while editing MR:
How Has This Been Tested?
Test Impact
Added cypress test
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main