-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardware profile table #3573
Add hardware profile table #3573
Conversation
@vconzola Hi, can you check the screenshots? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpanshug I prefer to keep everything in the root const.ts
file because we use different names for the column variables. Just let you know in advance so it's easier for you to rebase if needed.
@DaoDaoNoCode A couple comments questions...
|
@vconzola Hi, thanks for the feedback.
|
a5f3cf8
to
eed3c61
Compare
@vconzola I addressed the feedback as suggested. Can you check it again? |
eed3c61
to
55bdf24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3573 +/- ##
==========================================
+ Coverage 85.17% 85.25% +0.07%
==========================================
Files 1380 1390 +10
Lines 31542 31697 +155
Branches 8818 8853 +35
==========================================
+ Hits 26865 27022 +157
+ Misses 4677 4675 -2
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Thanks @DaoDaoNoCode This LGTM. I think it looks better with the smaller font for the section headers. Regarding the confirmation dialog, leave it out for now. I've started a thread within the UXD channel to talk about this, because we're inconsistent in different parts of the UI currently. I'll let you know what we decide, but I don't think that should block you from getting your PR merged, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
looks great
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: https://issues.redhat.com/browse/RHOAIENG-16254
Description
Added the table for the hardware profiles.
Main table:
Expandable sections:
There are 3 tables inside, if there is no data in the table, the corresponding nested table will be hidden.
Filters:
You can filter by Name and Enable columns.
Disable hardware profile modal:
Delete modal:
How Has This Been Tested?
opendatahub
namespacenodeSelectors
,identifiers
andtolerations
fields inspec
to see how the expandable section shows the tablesTest Impact
Added cypress tests for this page.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main