-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment mode select for kserve raw #3574
Add deployment mode select for kserve raw #3574
Conversation
Skipping CI for Draft Pull Request. |
9fe89e9
to
9526799
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3574 +/- ##
==========================================
- Coverage 85.19% 85.17% -0.02%
==========================================
Files 1382 1383 +1
Lines 31572 31624 +52
Branches 8824 8839 +15
==========================================
+ Hits 26897 26937 +40
- Misses 4675 4687 +12
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hey @emilys314, is the |
In this PR, no it's not dynamic, but a future PR will make it dynamic. Unless we want to remove it completely |
9526799
to
d8e208c
Compare
I see. I didn’t include this default flag in my original mockup, but I think it could be a good idea to have it. We might just need to clarify what ‘default’ means in this context to ensure users understand. That said, I don’t think this is a blocker for the PR. I’ll think through this further and let you know if I decide to suggest any changes. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes https://issues.redhat.com/browse/RHOAIENG-16487
Figma https://www.figma.com/design/hKimcyeu6pgAoqKH1XrqmY/Support-KServe-RawDeployment-mode?node-id=231-2365&node-type=canvas&t=KepUcCxzaanRkMU8-0
Description
First part of adding kserve raw model deployments. This adds the deployment mode dropdown to single serving (kserve) modals. What is done is basically adding
...DeploymentMode: RawDeployment
and the corresponding labels for auth / routing. The backend model controller takes care of the rest.Changing the deployment mode on an existing deployment is not supported so it will be disabled on edit. However the
assembleInferenceService()
does properly replace the labels and annotations.The deployment mode dropdown will also show up in NIM
How Has This Been Tested?
?devFeatureFlags
to the URL and make sure the kserve raw is set to false(Public endpoint without auth doesn't work)
Test Impact
cypress and jest tests added
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main