-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress e2e Test Enhancement - servingRuntimes - Added logic to delete template prior to test execution #3576
Cypress e2e Test Enhancement - servingRuntimes - Added logic to delete template prior to test execution #3576
Conversation
increase card timeout and delete active wait
…e/odh-dashboard into cypress-RHOAIENG-14368
…ttps://github.com/antowaddle/odh-dashboard into cypress-RHOAIENG-12649
…to cypress-RHOAIENG-16748
…n, if the template exist it is deleted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3576 +/- ##
=======================================
Coverage ? 85.19%
=======================================
Files ? 1380
Lines ? 31542
Branches ? 8818
=======================================
Hits ? 26872
Misses ? 4670
Partials ? 0 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-16748
Description
Added logic to check if a template exists, if it exists it is deleted, if not the test proceeds as normal. This enhancement will ensure the test is more resilient and was originally added to backlog when test was merged.
How Has This Been Tested?
Test Impact
How to run
After exporting the test-variables.yml we have 2 different ways:
Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testSingleServingRuntimeCreation.cy.ts & testMultiModelServingRuntimeCreation.cy.ts can be run.
Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main