Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress e2e Test Enhancement - servingRuntimes - Added logic to delete template prior to test execution #3576

Merged

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Dec 13, 2024

https://issues.redhat.com/browse/RHOAIENG-16748

Description

Added logic to check if a template exists, if it exists it is deleted, if not the test proceeds as normal. This enhancement will ensure the test is more resilient and was originally added to backlog when test was merged.

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test
  • test-variables.yml should be configured properly
  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
  • I've tested the enhancement on both RHOAI and ODH, both positive (no template) and negative (template exists) scenarios covered.
    image
    image
    image

Test Impact

  • None, this is a test

How to run

After exporting the test-variables.yml we have 2 different ways:

Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testSingleServingRuntimeCreation.cy.ts & testMultiModelServingRuntimeCreation.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command

  • npx cypress run --spec "cypress/tests/e2e/settings/servingRuntimes/testSingleServingRuntimeCreation.cy.ts" --browser chrome
  • npx cypress run --spec "cypress/tests/e2e/settings/servingRuntimes/testMultiModelServingRuntimeCreation.cy.ts" --browser chrome

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

antowaddle and others added 30 commits November 20, 2024 17:07
increase card timeout and delete active wait
@openshift-ci openshift-ci bot requested review from pnaik1 and ppadti December 13, 2024 16:14
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d402803). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3576   +/-   ##
=======================================
  Coverage        ?   85.19%           
=======================================
  Files           ?     1380           
  Lines           ?    31542           
  Branches        ?     8818           
=======================================
  Hits            ?    26872           
  Misses          ?     4670           
  Partials        ?        0           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d402803...0d26936. Read the comment docs.

Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Dec 16, 2024
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@manosnoam manosnoam added the lgtm label Dec 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 515dbef into opendatahub-io:main Dec 16, 2024
6 checks passed
@antowaddle antowaddle deleted the cypress-RHOAIENG-16748 branch December 20, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants