Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for typed icons in dark theme, make sizes consistent #3581

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

Closes RHOAIENG-16685

Description

Update background and foreground colors for icons depicting resource types. Make all resource icons on pages consistent in size.

How Has This Been Tested?

Tested all pages and verified the icons colors are correct in both dark and light themes

Test Impact

No automated test capability as these are purely visual changes

Screen shots

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

/cc @tobiastal @simrandhaliw @kywalker-rh

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 62.31884% with 26 lines in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (548ad3d) to head (a8cf3be).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/concepts/design/utils.ts 61.76% 26 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3581      +/-   ##
==========================================
- Coverage   85.18%   85.14%   -0.05%     
==========================================
  Files        1380     1382       +2     
  Lines       31542    31639      +97     
  Branches     8818     8864      +46     
==========================================
+ Hits        26869    26938      +69     
- Misses       4673     4701      +28     
Files with missing lines Coverage Δ
frontend/src/concepts/design/HeaderIcon.tsx 100.00% <100.00%> (ø)
frontend/src/concepts/design/InfoGalleryItem.tsx 100.00% <ø> (ø)
...creens/detail/overview/components/OverviewCard.tsx 94.44% <ø> (ø)
...serverModels/deployedModels/DeployedModelsCard.tsx 88.88% <ø> (ø)
frontend/src/concepts/design/utils.ts 71.97% <61.76%> (-3.15%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 548ad3d...a8cf3be. Read the comment docs.

--ai-organize--BackgroundColor: #CA6C0F;
--ai-organize--IconColor: #f2f2f2;

--ai-training--BackgroundColor: #37A3A3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not be referencing the color variables instead of the values themselves?

Suggested change
--ai-training--BackgroundColor: #37A3A3;
--ai-training--BackgroundColor: var(--pf-t--color--teal--50);

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, tobiastal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

New changes are detected. LGTM label has been removed.

@openshift-merge-bot openshift-merge-bot bot merged commit 7852a7f into opendatahub-io:main Dec 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants