-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for typed icons in dark theme, make sizes consistent #3581
Fix for typed icons in dark theme, make sizes consistent #3581
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
==========================================
- Coverage 85.18% 85.14% -0.05%
==========================================
Files 1380 1382 +2
Lines 31542 31639 +97
Branches 8818 8864 +46
==========================================
+ Hits 26869 26938 +69
- Misses 4673 4701 +28
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
86ce969
to
a8cf3be
Compare
--ai-organize--BackgroundColor: #CA6C0F; | ||
--ai-organize--IconColor: #f2f2f2; | ||
|
||
--ai-training--BackgroundColor: #37A3A3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not be referencing the color variables instead of the values themselves?
--ai-training--BackgroundColor: #37A3A3; | |
--ai-training--BackgroundColor: var(--pf-t--color--teal--50); |
a8cf3be
to
b912ac8
Compare
b912ac8
to
a67907d
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, tobiastal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a67907d
to
db1c391
Compare
New changes are detected. LGTM label has been removed. |
Closes RHOAIENG-16685
Description
Update background and foreground colors for icons depicting resource types. Make all resource icons on pages consistent in size.
How Has This Been Tested?
Tested all pages and verified the icons colors are correct in both dark and light themes
Test Impact
No automated test capability as these are purely visual changes
Screen shots
Request review criteria:
Self checklist (all need to be checked):
/cc @tobiastal @simrandhaliw @kywalker-rh