Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hopeful fix for flakey mr test #3586

Merged

Conversation

gitdallas
Copy link
Contributor

@gitdallas gitdallas commented Dec 17, 2024

Description

thinking a possible reason for the failure (which i've never been able to reproduce locally) is that the dropdown menu gets clicked before it closes from the first selection.

originally tried a fix is to check for it to be closed before attempting to open it - but it was getting some "dom changed" error

this PR is now separating the two "unsupported platform" tests into their own so it doesn't have to deal with whatever issue is happening when flicking between two

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@gitdallas gitdallas force-pushed the fix/flakey-deployModel-test branch 2 times, most recently from e815eef to 51c739d Compare December 17, 2024 19:57
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
@gitdallas gitdallas force-pushed the fix/flakey-deployModel-test branch from d93430a to 921bcf8 Compare December 17, 2024 21:26
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.31%. Comparing base (5d3efb2) to head (921bcf8).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3586      +/-   ##
==========================================
+ Coverage   85.20%   85.31%   +0.11%     
==========================================
  Files        1381     1391      +10     
  Lines       31592    31747     +155     
  Branches     8832     8867      +35     
==========================================
+ Hits        26919    27086     +167     
+ Misses       4673     4661      -12     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065da14...921bcf8. Read the comment docs.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - hard to verify this really fixes the flake, but it's a harmless change if it doesn't and it seems logical that it would.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit da671d0 into opendatahub-io:main Dec 18, 2024
6 checks passed
@gitdallas gitdallas deleted the fix/flakey-deployModel-test branch December 19, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants