-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the 4 edge case for main page #3599
Fixed the 4 edge case for main page #3599
Conversation
homePage.initHomeIntercepts({ | ||
disableModelRegistry: true, | ||
disableModelServing: true, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to test the inverse case here - leave these feature flags on, and instead disable the backend components. That's what was failing before. You can remove the initHomeIntercepts
call here and instead call:
cy.interceptOdh(
'GET /api/dsc/status',
mockDscStatus({
installedComponents: {
kserve: false,
'model-mesh': false,
'model-registry-operator': false,
},
}),
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
RHOAIENG-16483
How Has This Been Tested?
This has to be tested on a cluster that has the backend components for model registry and serving disabled
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main