Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Failing Cypress Test - testEnabledISVs.cy.ts #3607

Merged
merged 44 commits into from
Jan 1, 2025

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Dec 31, 2024

https://issues.redhat.com/browse/RHOAIENG-17005

Description

  • Created a new custom Util that parses /manifests/rhoai/shared/apps/rhoai/rhoai-app.yaml
  • RHOAI visibility is now verified based on 'hidden' value from rhoai-app.yaml
  • Updated test logic to incorporate using the new Custom Utility

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test
  • test-variables.yml should be configured properly
  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
  • This test has been tested locally against a RHOAI cluster and ODH Cluster running 2.17
    image

Test Impact

None, this is a test

How to run?

Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testEnabledISVs.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/applications/explore/testEnabledISVs.cy.ts" --browser chrome

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

antowaddle and others added 30 commits November 20, 2024 17:07
increase card timeout and delete active wait
@openshift-ci openshift-ci bot requested review from alexcreasy and ppadti December 31, 2024 14:50
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.11%. Comparing base (0a8fef2) to head (5b17bf5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3607      +/-   ##
==========================================
- Coverage   85.13%   85.11%   -0.03%     
==========================================
  Files        1395     1395              
  Lines       32041    32041              
  Branches     8979     8979              
==========================================
- Hits        27279    27271       -8     
- Misses       4762     4770       +8     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8fef2...5b17bf5. Read the comment docs.

@manosnoam manosnoam self-requested a review January 1, 2025 09:50
@manosnoam
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jan 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 1, 2025
@manosnoam manosnoam added the lgtm label Jan 1, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a0a31d8 into opendatahub-io:main Jan 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants