Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation for kserve servereless #3629

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

lucferbux
Copy link
Contributor

Description

Fix: https://issues.redhat.com/browse/RHOAIENG-17640

Add annotation for kserve serverless per requested.

How Has This Been Tested?

Added unit testing and deployed a model:

  1. Deploy a new kserve model
  2. Check that the inferenceservice contains the annotation

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and mturley January 9, 2025 17:57
@lucferbux lucferbux force-pushed the rhoaieng-17640 branch 2 times, most recently from 9fd2f42 to eba0011 Compare January 9, 2025 18:03
@lucferbux lucferbux force-pushed the rhoaieng-17640 branch 2 times, most recently from bac448c to c66f8bb Compare January 9, 2025 19:25
@emilys314
Copy link
Contributor

I did a quick test deploying a serverless model and it applied the deploymentMode tag

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.82%. Comparing base (3ea00fd) to head (0ab35ba).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3629      +/-   ##
==========================================
- Coverage   85.82%   85.82%   -0.01%     
==========================================
  Files        1419     1419              
  Lines       32644    32652       +8     
  Branches     9167     9166       -1     
==========================================
+ Hits        28018    28023       +5     
- Misses       4626     4629       +3     
Files with missing lines Coverage Δ
frontend/src/api/k8s/inferenceServices.ts 94.69% <100.00%> (-0.19%) ⬇️
frontend/src/k8sTypes.ts 100.00% <100.00%> (ø)
...d/src/pages/modelServing/screens/projects/utils.ts 93.28% <100.00%> (+0.20%) ⬆️
frontend/src/pages/modelServing/utils.ts 92.94% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea00fd...0ab35ba. Read the comment docs.

@emilys314
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 88db0fb into opendatahub-io:main Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants