Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parseCommandLine: Add unit test for multi-line input, remove incorrect help text #3634

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Jan 10, 2025

Followup to #3592 and #3633.
Resolves https://issues.redhat.com/browse/RHOAIENG-16900.

Description

Adds one more test based on comments on #3633, and removes the now-incorrect help text directing users to only have one argument per line now that we support single-line arg lists.

Help text before:

Screenshot 2025-01-10 at 12 06 25 PM

Help text after:

Screenshot 2025-01-10 at 12 13 50 PM

How Has This Been Tested?

No manual testing, this is just a unit test and a microcopy change.

Test Impact

See new unit test - just making sure the util still handles multi-line args properly.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@mturley
Copy link
Contributor Author

mturley commented Jan 10, 2025

/hold
Needs to wait for #3633 to merge.

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Jan 10, 2025
@mturley mturley mentioned this pull request Jan 10, 2025
6 tasks
@mturley mturley closed this Jan 10, 2025
@mturley mturley reopened this Jan 10, 2025
@mturley
Copy link
Contributor Author

mturley commented Jan 10, 2025

cc @vconzola @yih-wang

@mturley
Copy link
Contributor Author

mturley commented Jan 10, 2025

/retest

@YuliaKrimerman
Copy link
Contributor

/lgtm

@vconzola
Copy link

lgtm

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (f03527b) to head (c038ede).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3634      +/-   ##
==========================================
+ Coverage   85.41%   85.44%   +0.03%     
==========================================
  Files        1406     1406              
  Lines       32325    32325              
  Branches     9069     9069              
==========================================
+ Hits        27609    27619      +10     
+ Misses       4716     4706      -10     
Files with missing lines Coverage Δ
...projects/kServeModal/ServingRuntimeArgsSection.tsx 94.11% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03527b...c038ede. Read the comment docs.

…t help text

Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
@mturley mturley force-pushed the parsecommandline-multiline-test branch from c038ede to 9f61f9e Compare January 10, 2025 18:45
@openshift-ci openshift-ci bot removed the lgtm label Jan 10, 2025
@mturley
Copy link
Contributor Author

mturley commented Jan 10, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Jan 10, 2025
Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: gitdallas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bbb0bc9 into opendatahub-io:main Jan 10, 2025
4 checks passed
@mturley mturley deleted the parsecommandline-multiline-test branch January 10, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants