-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parseCommandLine: Add unit test for multi-line input, remove incorrect help text #3634
parseCommandLine: Add unit test for multi-line input, remove incorrect help text #3634
Conversation
/hold |
/retest |
/lgtm |
lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3634 +/- ##
==========================================
+ Coverage 85.41% 85.44% +0.03%
==========================================
Files 1406 1406
Lines 32325 32325
Branches 9069 9069
==========================================
+ Hits 27609 27619 +10
+ Misses 4716 4706 -10
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…t help text Signed-off-by: Mike Turley <mike.turley@alum.cs.umass.edu>
c038ede
to
9f61f9e
Compare
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: gitdallas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Followup to #3592 and #3633.
Resolves https://issues.redhat.com/browse/RHOAIENG-16900.
Description
Adds one more test based on comments on #3633, and removes the now-incorrect help text directing users to only have one argument per line now that we support single-line arg lists.
Help text before:
Help text after:
How Has This Been Tested?
No manual testing, this is just a unit test and a microcopy change.
Test Impact
See new unit test - just making sure the util still handles multi-line args properly.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main