Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress e2e Test - Verifies users can start, stop, launch and delete a running workbench from project details page #3637

Merged

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Jan 13, 2025

https://issues.redhat.com/browse/RHOAIENG-17502

Description

Migrate ODS-1818 & ODS-1823 to Cypress

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test
  • test-variables.yml should be configured properly
  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
  • Locally against a PSI cluster and ODH-Nightly
    image

How to run?

After exporting the test-variables.yml we have 2 different ways:

Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testWorkbenchControlSuite.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/workbenches/testWorkbenchControlSuite.cy.ts" --browser chrome

or Execute 'npx cypress run --env grepTags=@ODS-1818'

Test Impact

  • None - this is already a test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

antowaddle and others added 30 commits November 20, 2024 17:07
increase card timeout and delete active wait
@antowaddle antowaddle marked this pull request as ready for review January 13, 2025 12:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (ebc2c66) to head (7ca7ca1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3637      +/-   ##
==========================================
- Coverage   85.78%   85.78%   -0.01%     
==========================================
  Files        1419     1419              
  Lines       32684    32684              
  Branches     9191     9191              
==========================================
- Hits        28038    28037       -1     
- Misses       4646     4647       +1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc2c66...7ca7ca1. Read the comment docs.

@FedeAlonso
Copy link
Contributor

/lgtm

@FedeAlonso
Copy link
Contributor

image
Tested on RHOAI 2.17

@openshift-ci openshift-ci bot removed the lgtm label Jan 13, 2025
@FedeAlonso
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2025
@openshift-ci openshift-ci bot removed the lgtm label Jan 13, 2025
@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2025
@openshift-ci openshift-ci bot removed the lgtm label Jan 13, 2025
@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2025
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: FedeAlonso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 95d2b64 into opendatahub-io:main Jan 13, 2025
6 checks passed
@antowaddle antowaddle deleted the cypress-RHOAIENG-17502 branch January 14, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants