Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: workbenches e2e test. Use PVC Display Name #3638

Conversation

FedeAlonso
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-18051

Description

As the issue with the PVC showing it's name instead of the Display Name in the UI (https://issues.redhat.com/browse/RHOAIENG-16239) has been fixed, we need to update the Workbenches test.
It's been failing in the lasts nightlies
image

How Has This Been Tested?

$ npx cypress run --spec "**/workbenches.cy.ts" --browser chrome
image

Test Impact

Fix for workbenches.ct.ts test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@antowaddle
Copy link
Contributor

/lgtm

@antowaddle
Copy link
Contributor

/approved

Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (3ea00fd) to head (829ab28).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3638      +/-   ##
==========================================
- Coverage   85.82%   85.80%   -0.03%     
==========================================
  Files        1419     1419              
  Lines       32644    32644              
  Branches     9167     9167              
==========================================
- Hits        28018    28011       -7     
- Misses       4626     4633       +7     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea00fd...829ab28. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 6eedf7e into opendatahub-io:main Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants