Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of the path to oauth for impersonate user #3640

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Jan 13, 2025

Description

Fixes the URL path to oath when the dev server is running agains an RHOAI dashboard

How Has This Been Tested?

  • For a cluster whose oath route is not oauth-openshift, Edit .env.local and set DEV_IMPERSONATE_USER and DEV_IMPERSONATE_PASSWORD to a valid combo and set DEV_OAUTH_PREFIX to the correct route.
  • Run the dev server
  • In the dev dashboard, select the user menu and Start impersonate
  • Verify there are no errors and you now see only projects that DEV_IMPERSONATE_USER should see.

Test Impact

None, dev mode only

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

@openshift-ci openshift-ci bot requested review from Gkrumbach07 and ppadti January 13, 2025 21:28
@jeff-phillips-18 jeff-phillips-18 changed the title Fix path to oath when dev impersonating a user Allow override of the path to oauth for impersonate user Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.76%. Comparing base (ebc2c66) to head (552ecf1).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3640      +/-   ##
==========================================
- Coverage   85.78%   85.76%   -0.02%     
==========================================
  Files        1419     1419              
  Lines       32684    32684              
  Branches     9191     9191              
==========================================
- Hits        28038    28033       -5     
- Misses       4646     4651       +5     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc2c66...552ecf1. Read the comment docs.

@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0ce1fbb into opendatahub-io:main Jan 14, 2025
6 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the impersonate-fix branch January 15, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants