-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to show error message for the tiles on the enabled applications page. #3641
feat: add ability to show error message for the tiles on the enabled applications page. #3641
Conversation
Hi @yzhao583. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3641 +/- ##
==========================================
+ Coverage 84.05% 84.27% +0.22%
==========================================
Files 1432 1432
Lines 33479 33489 +10
Branches 9279 9284 +5
==========================================
+ Hits 28140 28223 +83
+ Misses 5339 5266 -73
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
Also is there any tests we can add for the new functionality for integration apps? |
…ttps://github.com/yzhao583/odh-dashboard into NVPE-38-Error-handling-in-enabling-NIM-application
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: emilys314 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7ffc255
into
opendatahub-io:main
Jira: https://issues.redhat.com/browse/NVPE-38
Description
Add the ability to show error messages for the tiles on the enabled applications page.
How Has This Been Tested?
Tested locally.
Test Impact
Enabled
page, a tile for NIM should be there.Enabled
page, there should be adisabled
button on the top-right corner of the NIM tile.disabled
button, a popover showing error message should be displayed.Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main