Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to show error message for the tiles on the enabled applications page. #3641

Conversation

yzhao583
Copy link
Contributor

@yzhao583 yzhao583 commented Jan 14, 2025

Jira: https://issues.redhat.com/browse/NVPE-38

Description

Add the ability to show error messages for the tiles on the enabled applications page.
image

How Has This Been Tested?

Tested locally.

Test Impact

  • Enable NIM by providing a valid API key -> go to the Enabled page, a tile for NIM should be there.
  • Go to console to change the API to invalid -> go to the Enabled page, there should be a disabled button on the top-right corner of the NIM tile.
  • Click the disabled button, a popover showing error message should be displayed.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and mturley January 14, 2025 06:29
@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Jan 14, 2025
Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

Hi @yzhao583. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.27%. Comparing base (bfe6c12) to head (40cc26d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/components/OdhAppCard.tsx 0.00% 5 Missing ⚠️
...nd/src/utilities/useWatchIntegrationComponents.tsx 72.72% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
+ Coverage   84.05%   84.27%   +0.22%     
==========================================
  Files        1432     1432              
  Lines       33479    33489      +10     
  Branches     9279     9284       +5     
==========================================
+ Hits        28140    28223      +83     
+ Misses       5339     5266      -73     
Files with missing lines Coverage Δ
frontend/src/types.ts 100.00% <ø> (ø)
...nd/src/utilities/useWatchIntegrationComponents.tsx 84.74% <72.72%> (+44.74%) ⬆️
frontend/src/components/OdhAppCard.tsx 61.90% <0.00%> (-1.00%) ⬇️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe6c12...40cc26d. Read the comment docs.

@emilys314
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Jan 14, 2025
@emilys314
Copy link
Contributor

Also is there any tests we can add for the new functionality for integration apps?

@yzhao583 yzhao583 requested a review from emilys314 January 16, 2025 09:17
@emilys314
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emilys314

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7ffc255 into opendatahub-io:main Jan 16, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants