Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide disabled kebab for connections owned by DSC #3642

Merged

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Jan 14, 2025

Closes: RHOAIENG-17142

Description

Hides the edit and delete options for connections owned by DSC. Since the admin will never be able to enable these actions, there's no need for them to be visible.

How Has This Been Tested?

Tested locally

Test Impact

No tests changed

Screenshots

Before, with edit and delete disabled:
Screenshot 2025-01-14 at 11 19 20 AM

After, edit and delete hidden:
Screenshot 2025-01-14 at 11 20 04 AM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from mturley and pnaik1 January 14, 2025 16:27
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (95d2b64) to head (d82ecb3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3642      +/-   ##
==========================================
+ Coverage   85.75%   85.78%   +0.02%     
==========================================
  Files        1419     1419              
  Lines       32684    32688       +4     
  Branches     9191     9195       +4     
==========================================
+ Hits        28027    28040      +13     
+ Misses       4657     4648       -9     
Files with missing lines Coverage Δ
.../pages/connectionTypes/ConnectionTypesTableRow.tsx 70.17% <100.00%> (+2.25%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d2b64...d82ecb3. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 960b099 into opendatahub-io:main Jan 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants