-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply hardware profile to notebook image settings table #3645
Apply hardware profile to notebook image settings table #3645
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3645 +/- ##
==========================================
- Coverage 84.26% 84.17% -0.10%
==========================================
Files 1450 1452 +2
Lines 33766 33823 +57
Branches 9353 9369 +16
==========================================
+ Hits 28454 28471 +17
- Misses 5312 5352 +40
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@DaoDaoNoCode , I created notebook image with a new option(ex: gpu) for rest of the functionality mentioned are working as expected |
@DaoDaoNoCode , thanks for the changes, that works well |
frontend/src/pages/BYONImages/BYONImageModal/HardwareProfileIdentifierMultiselect.tsx
Show resolved
Hide resolved
frontend/src/pages/BYONImages/BYONImageModal/HardwareProfileIdentifierMultiselect.tsx
Show resolved
Hide resolved
d8f7675
to
c9199e5
Compare
Change the hardware profile part to reuse the current recommended accelerator identifiers annotation for better migrating and avoiding some bugs. |
edc1ccc
to
2f39c85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
10d7434
into
opendatahub-io:main
JIRA: RHOAIENG-16258
Description
Apply the hardware profiles to the notebook image settings page. This remains unchanged when the hardware profile flag is disabled. When it's enabled, do the following changes:
Recommended identifiers
withRecommended hardware profiles
and put all the hardware profiles that has the selected identifier (as long as at least one identifier is included in the hardware profile node resources, we think that hardware profile is recommended)How Has This Been Tested?
Test Impact
Added a unit test to test the recommended hardware profile filter function, and added a cypress test to test the pre-fill node resources table based on the search params in the URL.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main