Cypress e2e Test - Verify That "Usage Data Collection" Can Be Set In "Cluster Settings" #3647
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3647 +/- ##
==========================================
- Coverage 85.79% 85.78% -0.02%
==========================================
Files 1419 1419
Lines 32688 32688
Branches 9195 9195
==========================================
- Hits 28044 28040 -4
- Misses 4644 4648 +4 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
@ConorOM1 Good work here, 2 very minor comments, otherwise lgtm.
|
|
||
| it( | ||
| 'Verify Usage Data Collection can be Enabled/Disabled', | ||
| { tags: ['@Sanity', '@ODS-1218', '@Dashboard', '@ExcludeOnODH'] }, |
There was a problem hiding this comment.
@SanitySet1 - please add this tag also, it's something i wanted to discuss on our call today.
| @@ -49,7 +49,7 @@ export const getCustomResource = ( | |||
| kind: string, | |||
| labelSelector: string, | |||
| ): Cypress.Chainable<CommandLineResult> => { | |||
| const ocCommand = `Oc Get kind=${kind}, label_selector=${labelSelector}, namespace=${resourceNamespace}`; | |||
| const ocCommand = `oc get ${kind} -l ${labelSelector} -n ${resourceNamespace}`; | |||
There was a problem hiding this comment.
Can you execute the other related tests that use this function also please? Just to ensure that they are also still working.
There was a problem hiding this comment.
I don't see it in use anywhere else at the moment ?
There was a problem hiding this comment.
Yeah, I'm doing a search now and seeing the same thing. I think you are good then, apologies.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 67669d6
into
opendatahub-io:main
https://issues.redhat.com/browse/RHOAIENG-17801
Description
Migrate ODS-1218 to Cypress
How Has This Been Tested?
An oc login should be performed in the cluster before running the test
test-variables.yml should be configured properly
Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
Tested against ODH-Nightly & RHOAI nightly
How to Run
After exporting the test-variables.yml we have 2 different ways:
Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testDataCollection.cy.ts can be run.
Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/settings/clusterSettings/testDataCollection.cy.ts" --browser chrome
Test Impact:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main