Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed fields to be UTC and duration to be more descriptive #3649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Jan 15, 2025

https://issues.redhat.com/browse/RHOAIENG-13774

Description

Screenshot 2025-01-15 at 4 48 56 PM Screenshot 2025-01-15 at 4 49 52 PM

The pipeline runs detail pages are changed to UTC time zones and duration time is more consistent

How Has This Been Tested?

npm run test:unit **/time.spec.ts

Test Impact

Edited the time.spec.ts file

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rsun19 rsun19 force-pushed the format-runs-duration-time branch 2 times, most recently from ecda238 to f2bc65e Compare January 16, 2025 14:59
@rsun19 rsun19 force-pushed the format-runs-duration-time branch 2 times, most recently from 2ae5734 to fda72cf Compare January 16, 2025 15:55
@rsun19 rsun19 force-pushed the format-runs-duration-time branch from fda72cf to fa6111f Compare January 16, 2025 18:59
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (0ce1fbb) to head (fa6111f).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3649      +/-   ##
==========================================
- Coverage   85.79%   84.27%   -1.53%     
==========================================
  Files        1419     1432      +13     
  Lines       32688    33486     +798     
  Branches     9195     9284      +89     
==========================================
+ Hits        28044    28219     +175     
- Misses       4644     5267     +623     
Files with missing lines Coverage Δ
...nes/content/pipelinesDetails/pipelineRun/utils.tsx 96.77% <ø> (ø)
frontend/src/utilities/time.ts 99.24% <100.00%> (-0.03%) ⬇️

... and 153 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce1fbb...fa6111f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants