Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read and show default deployment mode in deploy modal #3651

Conversation

emilys314
Copy link
Contributor

https://issues.redhat.com/browse/RHOAIENG-16489

Description

Read the kserve defaultDeploymentMode value on the DSC status. Then use this value for preselecting the default mode and also show which one is the default.

image

How Has This Been Tested?

This requires a nightly odh operator or the likes to have a default deployment mode other than serverless

  1. Uncheck the devFlag disableKServeRaw
  2. deploy a model
  3. check the "... (default)" and the preselected value in the modal

Test Impact

No tests added. the pulling of the DSC status value is pretty simple. and creating a cypress test for a different preselection seemed like overkill, but lmk.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

@yih-wang

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from manaswinidas and ppadti January 16, 2025 19:30
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.27%. Comparing base (67669d6) to head (5a3d408).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...src/pages/modelServing/useDefaultDeploymentMode.ts 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3651      +/-   ##
==========================================
+ Coverage   84.06%   84.27%   +0.20%     
==========================================
  Files        1432     1433       +1     
  Lines       33479    33500      +21     
  Branches     9279     9287       +8     
==========================================
+ Hits        28144    28231      +87     
+ Misses       5335     5269      -66     
Files with missing lines Coverage Δ
frontend/src/k8sTypes.ts 100.00% <ø> (ø)
...jects/kServeModal/KServeDeploymentModeDropdown.tsx 100.00% <100.00%> (ø)
...d/src/pages/modelServing/screens/projects/utils.ts 93.30% <100.00%> (+0.02%) ⬆️
...src/pages/modelServing/useDefaultDeploymentMode.ts 88.88% <88.88%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67669d6...5a3d408. Read the comment docs.

@yih-wang
Copy link

Looks good, thank you @emilys314!

@Griffin-Sullivan
Copy link
Contributor

/lgtm

Tested with the image on @emilys314's cluster and the correct default was selected!

@christianvogt
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 797dd8f into opendatahub-io:main Jan 21, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants