Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Show the GPU requests and limits in workbench table #3654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dpanshug
Copy link
Contributor

@dpanshug dpanshug commented Jan 17, 2025

RHOAIENG-16749

Description

Screenshot 2025-01-17 at 12 07 44 PM Screenshot 2025-01-17 at 12 08 01 PM

How Has This Been Tested?

Create a workbench and connect it to accelerators.

Test Impact

Added unit tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@xianli123

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Jan 17, 2025
@openshift-ci openshift-ci bot requested review from Gkrumbach07 and mturley January 17, 2025 07:30
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dpanshug
Copy link
Contributor Author

WIP: need to add same for the hardware profiles

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.25%. Comparing base (7ffc255) to head (f8d97c8).

Files with missing lines Patch % Lines
...s/screens/detail/notebooks/NotebookSizeDetails.tsx 57.14% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3654      +/-   ##
==========================================
- Coverage   84.26%   84.25%   -0.01%     
==========================================
  Files        1432     1434       +2     
  Lines       33489    33514      +25     
  Branches     9284     9297      +13     
==========================================
+ Hits        28218    28237      +19     
- Misses       5271     5277       +6     
Files with missing lines Coverage Δ
...r/screens/server/AcceleratorProfileSelectField.tsx 66.66% <100.00%> (-0.38%) ⬇️
...ller/screens/server/useAcceleratorCountWarning.tsx 100.00% <100.00%> (ø)
...ects/screens/detail/notebooks/NotebookTableRow.tsx 88.05% <100.00%> (+0.18%) ⬆️
...c/pages/projects/screens/detail/notebooks/utils.ts 100.00% <100.00%> (ø)
...s/screens/detail/notebooks/NotebookSizeDetails.tsx 68.42% <57.14%> (-31.58%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffc255...f8d97c8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant