fix null pointer error (RHOAIENG-18228) #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jooho lee <jlee@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jooho The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hdefazio
reviewed
Jan 16, 2025
internal/controller/serving/reconcilers/kserve_isvc_gateway_reconciler.go
Show resolved
Hide resolved
|
/lgtm |
openshift-merge-bot
bot
merged commit 0a97365
into
opendatahub-io:incubating
7 checks passed
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
* update global ca bundle logic and storage-config logic to follow up odh operator pr(1339) (#308) Signed-off-by: jooho lee <jlee@redhat.com> * disable dashboard and fix servingruntime display name Signed-off-by: jooho lee <jlee@redhat.com> * Use the main branch to build stable image tags, incubating for latest image tags (#316) Signed-off-by: Hannah DeFazio <h2defazio@gmail.com> * [RHOAIENG-13638] - Do not allow isvc creation in protected isvc (#311) * [RHOAIENG-13638] - Do not allow isvc creation in protected namespace chore: Fixes [RHOAIENG-13638] - Kserve model is not Ready after a kserve model is created and deleted from istio-system namespace Signed-off-by: Spolti <fspolti@redhat.com> * review suggestions Signed-off-by: Spolti <fspolti@redhat.com> * Update controllers/webhook/isvc_validator.go Co-authored-by: Edgar Hernández <ehernand@redhat.com> Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Spolti <fspolti@redhat.com> Co-authored-by: Edgar Hernández <ehernand@redhat.com> * update gitaction based on branch strategy change (#322) Signed-off-by: jooho lee <jlee@redhat.com> * feat: added performance metric grpahs config for nvidia nim (#320) * feat: added performance metric grpahs config for nvidia nim Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * chore: modifyed the runtime id annotation Co-authored-by: Edgar Hernández <ehernand@redhat.com> Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> --------- Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> Co-authored-by: Edgar Hernández <ehernand@redhat.com> * Add NIM flag logic (#312) Signed-off-by: mtrujillo <trujillo169@hotmail.com> * Grab the old release tag based on creation date Signed-off-by: Hannah DeFazio <h2defazio@gmail.com> * Updated the checkout code command Signed-off-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb> * Updated the checkout code command (#329) Signed-off-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb> Co-authored-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb> * Add reconciliation for Kserve Raw (#274) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * chore: added pagination support for nim catalog response (#332) Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * feat(mr): enable model registry inference reconcile (#326) Signed-off-by: Alessio Pragliola <seth.pro@gmail.com> * add upstream release metadata (#333) Signed-off-by: heyselbi <selbi@redhat.com> * Migration to kubebuilder v4 (#324) * Migration to kubebuilder v4 Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Restore MR E2Es Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Restore top-level files Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Cleaning Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Fixing Makefile and Containerfile Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Linter fixes Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Initial rework of manifests Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Fix manifests Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Fix lint issues Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Deactivate E2Es Because setup is not automated, yet. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Feedback: Filippe Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Feedback: Filippe Test differences after `go mod tidy` Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Apply suggestions from code review: Filippe Co-authored-by: Filippe Spolti <filippespolti@gmail.com> Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Feedback: Filippe * Pin go-toolset base image in Containerfile. * Add `gosec` linter Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Update config/prometheus/monitor.yaml Co-authored-by: Filippe Spolti <filippespolti@gmail.com> Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Feedback: Filippe * Small change to comments in Makefile, to make the text clearer. * Remove (again) `gosec` linter Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Fix panic on controller startup Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> --------- Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Co-authored-by: Filippe Spolti <filippespolti@gmail.com> * chore: use naming convention for resources created by nim (#340) * chore: use naming convention for resources created by nim Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * test: added assertions for dyamic nim resources name Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> --------- Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * chore: set nim runtime api call page size to 1000 (#344) Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * Nim enablement change default to managed and add clean up job (#342) * initial commit for clean up of nim and managed set as default Signed-off-by: mtrujillo <trujillo169@hotmail.com> * remove space Signed-off-by: mtrujillo <trujillo169@hotmail.com> * fix code length for linting Signed-off-by: mtrujillo <trujillo169@hotmail.com> * fixed comments / adjusted import Signed-off-by: mtrujillo <trujillo169@hotmail.com> --------- Signed-off-by: mtrujillo <trujillo169@hotmail.com> * chore: added new graph object for nim runtimes (#334) * chore: added new graph object for nim runtimes Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * chore: added REQUEST_OUTCOMES nim graph Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * chore: added fixed typo in nim query object Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * chore: fixed typo in nim query object Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * chore: added initial query for nim gpu cache usage Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * chore: rewrite queries for nim new graphs Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> --------- Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> * Update ovms to current build (#343) Signed-off-by: Steve Grubb <ausearch.1@gmail.com> Co-authored-by: Steve Grubb <ausearch.1@gmail.com> * Automatically inject expected ODH annotations to InferenceGraph and InferenceServices (#339) * Implementation of ODH defaulters for InferenceGraph and InferenceService On creation of InferenceGraph or InferenceService resources, the following default annotations will be added: * `serving.knative.openshift.io/enablePassthrough: true` * `sidecar.istio.io/inject: true` * `sidecar.istio.io/rewriteAppHTTPProbers: true` The annotations are added only for Serverless mode, and only if they are missing. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Feedback: Filippe Extract "ENABLE_WEBHOOKS" string to constant Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> --------- Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Authorization for InferenceGraph (Serverless) (#345) * Authorization for InferenceGraph (Serverless) This adds a new controller for KServe InferenceGraph resources. This new controller will have the responsibility of creating Authorino AuthConfig resources (similarly to InferenceServices case), when authorization is available in ODH platform. InferenceGraphs can now be annotated with `security.opendatahub.io/enable-auth: "true"` to secure InferenceGraphs and only serve requests that are authorized. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * Feedback: Filippe - Event when auth is not available Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> --------- Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> * [RHOAIENG-10293] add metrics resources for rawdeployment (#347) * [RHOAIENG-10293] add metrics resources for rawdeployment Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * [RHOAIENG-10293] address feedback Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> --------- Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * [RHOAIENG-16851] rawdeployment route bug fixes (#341) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> * fix null pointer error (RHOAIENG-18228) (#349) Signed-off-by: jooho lee <jlee@redhat.com> * remove old file Signed-off-by: jooho lee <jlee@redhat.com> update go.mod Signed-off-by: jooho lee <jlee@redhat.com> --------- Signed-off-by: jooho lee <jlee@redhat.com> Signed-off-by: Hannah DeFazio <h2defazio@gmail.com> Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Tomer Figenblat <tfigenbl@redhat.com> Signed-off-by: mtrujillo <trujillo169@hotmail.com> Signed-off-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb> Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> Signed-off-by: Alessio Pragliola <seth.pro@gmail.com> Signed-off-by: heyselbi <selbi@redhat.com> Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> Signed-off-by: Steve Grubb <ausearch.1@gmail.com> Co-authored-by: Hannah DeFazio <h2defazio@gmail.com> Co-authored-by: Filippe Spolti <filippespolti@gmail.com> Co-authored-by: Edgar Hernández <ehernand@redhat.com> Co-authored-by: Tomer Figenblat <tomer.figenblat@gmail.com> Co-authored-by: Marcus Trujillo <42344046+trujillm@users.noreply.github.com> Co-authored-by: Mariah Holder <marholde@marholde-thinkpadp16vgen1.rht.csb> Co-authored-by: Mariah Holder <94134625+mholder6@users.noreply.github.com> Co-authored-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> Co-authored-by: Tomer Figenblat <tfigenbl@redhat.com> Co-authored-by: Alessio Pragliola <83355398+Al-Pragliola@users.noreply.github.com> Co-authored-by: Selbi Nuryyeva <selbi@redhat.com> Co-authored-by: Steven Grubb <sgrubb@redhat.com> Co-authored-by: Steve Grubb <ausearch.1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When knative have some issues and if it did not deploy runtime, Address would not be set.
We should check this situation.
How Has This Been Tested?
Merge criteria: