Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest-pspec instead of pytest-progress #47

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lugi0
Copy link
Collaborator

@lugi0 lugi0 commented Nov 26, 2024

Implementation of #46

Signed-off-by: lugi0 <lgiorgi@redhat.com>
@lugi0 lugi0 added the kind/enhancement New feature or request label Nov 26, 2024
@lugi0 lugi0 linked an issue Nov 26, 2024 that may be closed by this pull request
@lugi0 lugi0 added the size/xs label Nov 26, 2024
@lugi0 lugi0 marked this pull request as draft November 26, 2024 16:49
@lugi0
Copy link
Collaborator Author

lugi0 commented Nov 26, 2024

Discuss in #46

@rnetser
Copy link
Collaborator

rnetser commented Dec 12, 2024

@lugi0 looked into using this plugin. i think we should continue using pytest-progress as it provides visibility on tests progress which is important mainly in ci. i think logging the test docs in this context is less valuable. wdyt?

@lugi0
Copy link
Collaborator Author

lugi0 commented Dec 12, 2024

@rnetser I honestly don't like how verbose pytest-progress is most of the time, but I agree that in CI it would be the better choice.
IMHO we can either use two configs (local, ci) if we wanted to have a common config for all, or we could just default to pytest-progress and let folks modify their local env to best suit their preferences

@rnetser
Copy link
Collaborator

rnetser commented Dec 15, 2024

@lugi0 I prefer not to have 2 configs and as the target here is mainly ci I think we should go with pytest-progress.

@rnetser
Copy link
Collaborator

rnetser commented Dec 18, 2024

@lugi0 can we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request size/xs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pytest-pspec instead of pytest-progress
2 participants