[WIP] add test for Raw kserve auth #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/verified', '/hold', '/lgtm'} |
Signed-off-by: Milind Waykole <mwaykole@mwaykole-thinkpadp1gen4i.bengluru.csb>
mwaykole
force-pushed
the
test_raw_auth
branch
from
fd9b77f to
906b6ec
Compare
for more information, see https://pre-commit.ci
rnetser
reviewed
Jan 12, 2025
Comment on lines
+191
to
+194
| return run_command( | ||
| command=shlex.split(f"oc create token -n {model_service_account.namespace} {model_service_account.name}") | ||
| )[1].strip() | ||
|
|
There was a problem hiding this comment.
please create a function and re-use in all places
| "model_namespace, s3_models_storage_uri", | ||
| [ | ||
| pytest.param( | ||
| {"name": "kserve-token-authentication"}, |
There was a problem hiding this comment.
Suggested change
| {"name": "kserve-token-authentication"}, | |
| {"name": "kserve-raw-token-authentication"}, |
| ], | ||
| indirect=True, | ||
| ) | ||
| class TestKserveTokenAuthenticationRaw: |
There was a problem hiding this comment.
let's split to rest and grpc; then test cross-domain with one protocol. this way we can re-use existing fixtures and not add new ones.
| @@ -90,7 +91,7 @@ def create_isvc( | |||
| if deployment_mode == KServeDeploymentType.SERVERLESS: | |||
There was a problem hiding this comment.
Suggested change
| if deployment_mode == KServeDeploymentType.SERVERLESS: | |
| if deployment_mode in (KServeDeploymentType.SERVERLESS, KServeDeploymentType.RAW_DEPLOYMENT): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.