Update Habana UBI image to fix CVE, GRPC issue and WARMUP issue #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
changed the title
dtrifiro
reviewed
Jan 15, 2025
Comment on lines
+85
to
+93
| pip install $(echo dist/*.whl)'[tensorizer]' jinja2>=3.1.5 --verbose | ||
|
|
||
| ENV HF_HUB_OFFLINE=1 \ | ||
| PORT=8000 \ | ||
| HOME=/home/vllm \ | ||
| VLLM_USAGE_SOURCE=production-docker-image | ||
| VLLM_USAGE_SOURCE=production-docker-image \ | ||
| VLLM_NO_USAGE_STATS=1 \ | ||
| VLLM_SKIP_WARMUP=true \ | ||
| PT_HPU_MAX_COMPOUND_OP_SIZE=10 |
There was a problem hiding this comment.
These changes seem unrelated (CVE fix + other). Can you split it up in separate commits and update the PR title accordingly?
There was a problem hiding this comment.
done... create three seperate commit
dtrifiro
approved these changes
Jan 15, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dtrifiro, vaibhavjainwiz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vaibhav Jain <vajain@redhat.com>
vaibhavjainwiz
force-pushed
the
update_adaptor_version
branch
from
430f937 to
13e45dc
Compare
Signed-off-by: Vaibhav Jain <vajain@redhat.com>
Signed-off-by: Vaibhav Jain <vajain@redhat.com>
vaibhavjainwiz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.