Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Running OSMetricsCollector before metric collection begins #587

Closed
wants to merge 2 commits into from

Conversation

khushbr
Copy link
Contributor

@khushbr khushbr commented Mar 26, 2021

Running OSMetricsCollector before metric collection begins to allow jTidMap to be persisted.

Fixes #: #586

Description of changes: OSMetricsCollector#collectMetrics() is responsible for persisting Thread related info in 'jTidMap'
In case the 'jTidMap' has not been updated and threadState is null, we return -1 when getNativeThreadId() is invoked. This happens during the first round of collectors execution, any collector executed before OSMetricsCollector will find the threadState as null in the 'jTidMap' and persist -1 value for threadID.

Tests:

If new tests are added, how long do the new ones take to complete

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@khushbr khushbr closed this May 7, 2021
@khushbr khushbr deleted the khushbr-main branch May 7, 2021 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant