feat: new unit tests for dbt models and macros #108
Conversation
Ian2012
requested review from
bmtcril and
Ian2012
and removed request for
bmtcril
| @@ -0,0 +1,25 @@ | |||
| name: Run all tests & checks | |||
There was a problem hiding this comment.
I think we probably don't need this, as we're running dbt test here:
https://github.com/openedx/aspects-dbt/blob/main/.github/workflows/coverage.yml#L47
Since dbt needs ClickHouse running, and alembic to have been run, we're just doing these tests in the Tutor / Aspects context there.
| @@ -14,7 +14,7 @@ profile: "aspects" | |||
| model-paths: ["models"] | |||
| analysis-paths: ["analyses"] | |||
| test-paths: ["tests"] | |||
| seed-paths: ["seeds"] | |||
| seed-paths: ["seeds","seeds-test"] | |||
There was a problem hiding this comment.
This one I'm not sure how we would shoehorn into the Aspects context, we obviously don't want these seeds loaded outside of CI. We may need to find / add a way to override the dbt_project.yml in Aspects. 🤔
| @@ -0,0 +1,53 @@ | |||
| {% macro drop_stale_tables(dryrun=False) %} | |||
There was a problem hiding this comment.
What's this for? :) Looks like it's not being used yet?
There was a problem hiding this comment.
We should get rid of this one. You should be able to add .DS_Store to ~/.gitignore to remove them globally. In VS Code you'd need to turn on 2 options for it to recognize the global file: "Search: Use Global Ignore Files" and "Search: Use Ignore Files", I think that's what fixed those files getting auto-added for me.
Part 1 of new unit tests
still using dev dbt-clickhouse version - need to update before deploying