-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move problem engagement MVs #93
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
704a6d3
to
c8360f2
Compare
This seems ok to me, once |
3a6813a
to
e539789
Compare
71b004f
to
91c79dd
Compare
feat: move problem engagement to an mv feat: move problem engagement to an mv feat: move problem engagement to an mv feat: move problem engagement to an mv feat: add subsection block id to items per subsection feat: add subsection block id to items per subsection fix: use section_id for section problem engagement fix: use section_id for section problem engagement fix: use section_id for section problem engagement fix: use section_id for section problem engagement fix: use section_id for section problem engagement
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR moves the problem engagement to an MV. A testing model called
fact_problem_engagement_v2
has been created to compare the old model to the new one.In the new model, records with empty
section_subsection_name
are skipped.Author concerns
The data in the new MVs will only be updated once a new problem event is triggered