Removing unencrypted credentials from model (#2220)

* refactor: removed unencrypted credentials from sap config model
openedx · Sep 10, 2024 · fa7bfe8 · fa7bfe8
1 parent 8b31c10
commit fa7bfe8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 17 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -17,6 +17,10 @@ Unreleased
 ----------
 * nothing unreleased
 
+[4.25.7]
+----------
+* refactor: removed unencrypted credentials from sap config model
+
 [4.25.6]
 ----------
 * refactor: making unencrypted credentials nullable so after removing refs tests can run

diff --git a/enterprise/__init__.py b/enterprise/__init__.py
@@ -2,4 +2,4 @@
 Your project description goes here.
 """
 
-__version__ = "4.25.6"
+__version__ = "4.25.7"
diff --git a/integrated_channels/sap_success_factors/models.py b/integrated_channels/sap_success_factors/models.py
@@ -74,14 +74,6 @@ class SAPSuccessFactorsEnterpriseCustomerConfiguration(EnterpriseCustomerPluginC
         (USER_TYPE_USER, 'User'),
         (USER_TYPE_ADMIN, 'Admin'),
     )
-    key = models.CharField(
-        max_length=255,
-        blank=True,
-        default='',
-        verbose_name="Client ID",
-        help_text=_("OAuth client identifier."),
-        null=True
-    )
 
     decrypted_key = EncryptedCharField(
         max_length=255,
@@ -138,14 +130,6 @@ def encrypted_key(self, value):
         verbose_name="SAP User ID",
         help_text=_("Success factors user identifier.")
     )
-    secret = models.CharField(
-        max_length=255,
-        blank=True,
-        default='',
-        verbose_name="Client Secret",
-        help_text=_("OAuth client secret."),
-        null=True
-    )
 
     decrypted_secret = EncryptedCharField(
         max_length=255,