-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding management command to remove expired pending group memberships #2040
Conversation
454124e
to
19f5224
Compare
|
||
def handle(self, *args, **options): | ||
queryset = EnterpriseGroupMembership.objects.all() | ||
if enterprise_arg := options.get("enterprise_customer"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we documenting the optional enterprise_customer
argument somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uhhh Let me add it to the doc string, it's not necessary for the overnight job that's to run however I liked the added flexibility for other users down the line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the doc string- I'll write a quick unit test for it just to be certain
enterprise/management/commands/remove_expired_pending_group_memberships.py
Outdated
Show resolved
Hide resolved
19f5224
to
39d7ff6
Compare
39d7ff6
to
66f7ef4
Compare
588bbde
to
872a80d
Compare
872a80d
to
01124b9
Compare
https://2u-internal.atlassian.net/browse/ENT-8524
In this PR:
/learners/
endpoint to account for groups that apply to all contextsapplies_to_all_contexts
flag on EnterpriseGroup recordsremove_expired_pending_group_memberships
that will remove pending membership records if they are older than 90 daysMerge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.