-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create DefaultEnterpriseEnrollmentRealization during bulk enrollment #2276
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,4 @@ | |
Your project description goes here. | ||
""" | ||
|
||
__version__ = "4.31.2" | ||
__version__ = "4.32.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
...prise/migrations/0228_alter_defaultenterpriseenrollmentrealization_realized_enrollment.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# Generated by Django 4.2.16 on 2024-10-29 21:30 | ||
|
||
from django.db import migrations, models | ||
import django.db.models.deletion | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
('enterprise', '0227_alter_defaultenterpriseenrollmentintention_content_type_and_more'), | ||
] | ||
|
||
operations = [ | ||
migrations.AlterField( | ||
model_name='defaultenterpriseenrollmentrealization', | ||
name='realized_enrollment', | ||
field=models.OneToOneField(on_delete=django.db.models.deletion.CASCADE, to='enterprise.enterprisecourseenrollment'), | ||
), | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -742,6 +742,20 @@ def pending_enterprise_customer_admin_user_model(): | |
return apps.get_model('enterprise', 'PendingEnterpriseCustomerAdminUser') | ||
|
||
|
||
def default_enterprise_enrollment_intention_model(): | ||
""" | ||
Returns the ``DefaultEnterpriseEnrollmentIntention`` class. | ||
""" | ||
return apps.get_model('enterprise', 'DefaultEnterpriseEnrollmentIntention') | ||
|
||
|
||
def default_enterprise_enrollment_realization_model(): | ||
""" | ||
Returns the ``DefaultEnterpriseEnrollmentRealization`` class. | ||
""" | ||
return apps.get_model('enterprise', 'DefaultEnterpriseEnrollmentRealization') | ||
|
||
|
||
def get_enterprise_customer(uuid): | ||
""" | ||
Get the ``EnterpriseCustomer`` instance associated with ``uuid``. | ||
|
@@ -1816,14 +1830,15 @@ def enroll_user(enterprise_customer, user, course_mode, *course_ids, **kwargs): | |
|
||
|
||
def customer_admin_enroll_user_with_status( | ||
enterprise_customer, | ||
user, | ||
course_mode, | ||
course_id, | ||
enrollment_source=None, | ||
license_uuid=None, | ||
transaction_id=None, | ||
force_enrollment=False, | ||
enterprise_customer, | ||
user, | ||
course_mode, | ||
course_id, | ||
enrollment_source=None, | ||
license_uuid=None, | ||
transaction_id=None, | ||
force_enrollment=False, | ||
is_default_auto_enrollment=False, | ||
): | ||
""" | ||
For use with bulk enrollment, or any use case of admin enrolling a user | ||
|
@@ -1910,6 +1925,12 @@ def customer_admin_enroll_user_with_status( | |
licensed_enrollment_obj.uuid, license_uuid, | ||
) | ||
enterprise_fulfillment_source_uuid = licensed_enrollment_obj.uuid | ||
|
||
if is_default_auto_enrollment: | ||
# Check for default enterprise enrollment intentions for enterprise customer associated | ||
# with the enrollment, and create a default enterprise enrollment realization if necessary. | ||
check_default_enterprise_enrollment_intentions_and_create_realization(enterprise_course_enrollment=obj) | ||
|
||
if created: | ||
# Note: this tracking event only caters to bulk enrollment right now. | ||
track_enrollment(PATHWAY_CUSTOMER_ADMIN_ENROLLMENT, user.id, course_id) | ||
|
@@ -1920,6 +1941,50 @@ def customer_admin_enroll_user_with_status( | |
return succeeded, created, enterprise_fulfillment_source_uuid | ||
|
||
|
||
def check_default_enterprise_enrollment_intentions_and_create_realization(enterprise_course_enrollment): | ||
""" | ||
Check if there are any default enrollment intentions for the given enterprise customer, | ||
and create corresponding realizations if they do not exist. | ||
""" | ||
enterprise_customer_uuid = enterprise_course_enrollment.enterprise_customer_user.enterprise_customer.uuid | ||
default_enrollment_intentions_for_customer = ( | ||
default_enterprise_enrollment_intention_model().available_objects.filter( | ||
enterprise_customer=enterprise_customer_uuid, | ||
) | ||
) | ||
default_enterprise_enrollment_intention = next( | ||
( | ||
intention for intention in default_enrollment_intentions_for_customer | ||
if intention.course_run_key == enterprise_course_enrollment.course_id | ||
), | ||
None | ||
) | ||
|
||
if not default_enterprise_enrollment_intention: | ||
LOGGER.info( | ||
"No default enrollment intention found for enterprise course enrollment %s", | ||
enterprise_course_enrollment.id | ||
) | ||
return None | ||
|
||
default_enterprise_enrollment_realization, created = ( | ||
default_enterprise_enrollment_realization_model().objects.get_or_create( | ||
intended_enrollment=default_enterprise_enrollment_intention, | ||
realized_enrollment=enterprise_course_enrollment, | ||
) | ||
) | ||
|
||
if created: | ||
LOGGER.info( | ||
"Created default enterprise enrollment realization for default enrollment " | ||
"intention %s and enterprise course enrollment %s", | ||
default_enterprise_enrollment_intention.uuid, | ||
enterprise_course_enrollment.id | ||
) | ||
|
||
return default_enterprise_enrollment_intention, default_enterprise_enrollment_realization | ||
Comment on lines
+1963
to
+1985
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. chefs kiss |
||
|
||
|
||
def customer_admin_enroll_user(enterprise_customer, user, course_mode, course_id, enrollment_source=None): | ||
""" | ||
For use with bulk enrollment, or any use case of admin enrolling a user | ||
|
@@ -2006,10 +2071,12 @@ def enroll_subsidy_users_in_courses(enterprise_customer, subsidy_users_info, dis | |
* 'course_mode': The course mode. | ||
* 'license_uuid' OR 'transaction_id': ID of either accepted form of subsidy. | ||
* 'force_enrollment' (bool, optional): Enroll user even enrollment deadline is expired (default False). | ||
* 'is_default_auto_enrollment' (bool, optional): If True, a related default enterprise enrollment | ||
realization will be created (default False). | ||
|
||
Example:: | ||
|
||
licensed_users_info: [ | ||
subsidy_users_info: [ | ||
{ | ||
'email': 'newuser@test.com', | ||
'course_run_key': 'course-v1:edX+DemoX+Demo_Course', | ||
|
@@ -2029,6 +2096,7 @@ def enroll_subsidy_users_in_courses(enterprise_customer, subsidy_users_info, dis | |
'transaction_id': '3a5312d722564db0a16e3d81f53a3718', | ||
}, | ||
] | ||
|
||
discount: (int) the discount offered to the learner for their enrollment. Subscription based enrollments | ||
default to 100 | ||
|
||
|
@@ -2057,6 +2125,7 @@ def enroll_subsidy_users_in_courses(enterprise_customer, subsidy_users_info, dis | |
transaction_id = subsidy_user_info.get('transaction_id') | ||
activation_link = subsidy_user_info.get('activation_link') | ||
force_enrollment = subsidy_user_info.get('force_enrollment', False) | ||
is_default_auto_enrollment = subsidy_user_info.get('is_default_auto_enrollment', False) | ||
|
||
if user_id and user_email: | ||
user = User.objects.filter(id=subsidy_user_info['user_id']).first() | ||
|
@@ -2088,6 +2157,7 @@ def enroll_subsidy_users_in_courses(enterprise_customer, subsidy_users_info, dis | |
license_uuid, | ||
transaction_id, | ||
force_enrollment=force_enrollment, | ||
is_default_auto_enrollment=is_default_auto_enrollment, | ||
) | ||
if succeeded: | ||
success_dict = { | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breadcrumb for future readers on
SoftDeletableModel
, TIL!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think the future change to always need to rely on
available_objects
was inspired by this issue thread.