fix: enrollment intention saves should not be blocked on catalog inclusion #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usion Before this commit, normal replication delays from discovery->catalog can easily result in enrollment intentions being un-saveable when simultaneously modifying catalog definitions to include the content. Conversely, normal replication delays can also allow saving an enrollment intention that would eventually become invalid due to content being removed from the catalog, creating a false sense of correctness. After this commit, we no longer assert during intention save() that the customer's catalogs actually contain the content. Instead, we assert that the content exists at all in the enterprise-catalog database by querying the customer- and catalog-agnostic `/api/v1/content-metadata/?content_identifiers=<content_key>` endpoint. Subsequent commits/PRs may introduce dynamic warning messaging (non-blocking) on django admin pages for the customer and intention when the intention's content key is not contained in the customer's catalogs. ENT-9840
|
Unfortunately, the API that I switched to ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, normal replication delays from discovery->catalog can easily result in enrollment intentions being un-saveable when simultaneously modifying catalog definitions to include the content. Conversely, normal replication delays can also allow saving an enrollment intention that would eventually become invalid due to content being removed from the catalog, creating a false sense of correctness.
After this commit, we no longer assert during intention save() that the customer's catalogs actually contain the content. Instead, we assert that the content exists at all in the enterprise-catalog database by querying the customer- and catalog-agnostic
/api/v1/content-metadata/?content_identifiers=<content_key>endpoint.Subsequent commits/PRs may introduce dynamic warning messaging (non-blocking) on django admin pages for the customer and intention when the intention's content key is not contained in the customer's catalogs.
ENT-9840