Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix absent notification message after submit Generate Exception … #31668

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: Fix absent notification message after submit Generate Exception … #31668

merged 1 commit into from
Nov 14, 2023

Conversation

Lunyachek
Copy link
Contributor

Description

After submitting Generate Exception Certificates button at Instructor/Certificates tab we have a problem with a message, which is hidden. Only empty div with background is shown.

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 30, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 30, 2023 •
edited
Loading

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211
Copy link

Hi @Lunyachek! Thank you for this contribution! As mentioned above, you'll need to fill out the CLA form in order to proceed. Please let me know if you have any questions. Thanks!

@Lunyachek
Copy link
Contributor Author

Hello @mphilbrick211! I'm contributing on behalf of Raccoongang

@mphilbrick211
Copy link

@idegtiarov - not sure who I should check with (happy to reach to someone else if needed), but could you check to make sure @Lunyachek is added to your entity agreement? I don't see him listed on our end.

@idegtiarov
Copy link
Contributor

@mphilbrick211 I added Stanislav to the RG CLA spreadsheet on Monday, @e0d confirmed that change already.

@mphilbrick211
Copy link

Hi @Lunyachek! Would you mind re-running the failing tests? Since you were added to the CLA the check should turn green once you re-run. Thanks!

@mphilbrick211
Copy link

Hi @Lunyachek friendly ping on this :)

@Lunyachek Lunyachek force-pushed the lunyachek/fix/absent-notification-message-certificate-exception-generation branch from 0db5457 to 05b5390 Compare March 11, 2023 09:47
@Lunyachek
Copy link
Contributor Author

Hi @Lunyachek friendly ping on this :)

Hi! @mphilbrick211 thank you!

@Lunyachek Lunyachek force-pushed the lunyachek/fix/absent-notification-message-certificate-exception-generation branch from 05b5390 to f41c170 Compare March 11, 2023 10:25
@mphilbrick211
Copy link

Thanks, @Lunyachek! I will have someone review for you.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 21, 2023
@Lunyachek Lunyachek force-pushed the lunyachek/fix/absent-notification-message-certificate-exception-generation branch from f41c170 to 8effb7f Compare June 27, 2023 10:01
@mphilbrick211
Copy link

Hi @Lunyachek - flagging for you that some tests are failing.

@Lunyachek
Copy link
Contributor Author

@mphilbrick211 I have updated branch and all checks have passed

@mphilbrick211
Copy link

Thanks, @Lunyachek!

@openedx/2u-aperture - This is ready for review. Thanks!

@hurtstotouchfire hurtstotouchfire added the needs maintainer attention Issue or PR specifically needs the attention of the maintainer. label Aug 30, 2023
@jsnwesson jsnwesson enabled auto-merge September 11, 2023 18:38
@jsnwesson jsnwesson disabled auto-merge September 11, 2023 18:41
@mphilbrick211
Copy link

Hi @Lunyachek and @jsnwesson - flagging that 2 new checks have popped up - please see here: https://discuss.openedx.org/t/minor-change-to-edx-platform-check-statuses/11131

@jsnwesson
Copy link
Contributor

@Lunyachek adding to @mphilbrick211 's comment, if you can rebase this PR with main and push it back up, it should be able to run the Pylint and Unit checks just fine. I'll leave it to you to do this since there's always a possibility of other changes appearing since you last rebased from main.

@jsnwesson jsnwesson added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 14, 2023
@justinhynes
Copy link
Contributor

Hi @Lunyachek, just reaching out again. If you could rebase your branch on the laster changes in master, we can go ahead and get this merged. Thanks for your time and effort.

@deborahgu
Copy link
Member

Hi @Lunyachek, just reaching out again. If you could rebase your branch on the latest master, we can go ahead and get this merged. Thanks for your time!

@Lunyachek Lunyachek force-pushed the lunyachek/fix/absent-notification-message-certificate-exception-generation branch from 0c95c34 to 9649e55 Compare October 30, 2023 16:58
@Lunyachek
Copy link
Contributor Author

Lunyachek commented Oct 30, 2023 •
edited
Loading

Hi @Lunyachek, just reaching out again. If you could rebase your branch on the latest master, we can go ahead and get this merged. Thanks for your time!

Hi! I have rebased the branch

@mphilbrick211
Copy link

Hi @deborahgu and @jsnwesson! This is all set.

@justinhynes justinhynes removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 14, 2023
@justinhynes
Copy link
Contributor

We have a team refinement session today. I'll unblock our ticket and bring it up for discussion.

@jsnwesson jsnwesson merged commit 3c40052 into openedx:master Nov 14, 2023
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@Lunyachek Lunyachek deleted the lunyachek/fix/absent-notification-message-certificate-exception-generation branch November 14, 2023 23:15
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnwesson jsnwesson jsnwesson approved these changes

@hurtstotouchfire hurtstotouchfire Awaiting requested review from hurtstotouchfire

Assignees
No one assigned
Labels
needs maintainer attention Issue or PR specifically needs the attention of the maintainer. open-source-contribution PR author is not from Axim or 2U
Projects
Aperture-Maintained
Status: Done
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Lunyachek @openedx-webhooks @mphilbrick211 @idegtiarov @jsnwesson @justinhynes @deborahgu @edx-pipeline-bot @itsjeyd @hurtstotouchfire