feat: Add a script to enhance JWKs in preparation for move from pyjwkest #32089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script accepts a signing JWK (presumably `JWT_PRIVATE_SIGNING_JWK`) and ensures that it has all of the precomputed private numbers that are required for top performance. This is necessary before moving away from pyjwkest to PyJWT for signing JWTs. See issue <openedx/edx-drf-extensions#290>. (Alternatively, one could remove the p, q, dp, dq, and qi params, but there is an unknown performance cost to doing so as we are not currently caching these keys, and the precompution happens on every load due to the way pyjwkest's API works.)
14 tasks
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
1 similar comment
|
EdX Release Notice: This PR has been deployed to the production environment. |
This was referenced Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script accepts a signing JWK (presumably
JWT_PRIVATE_SIGNING_JWK) and ensures that it has all of the precomputed private numbers that are required for top performance. This is necessary before moving away from pyjwkest to PyJWT for signing JWTs. See issue openedx/edx-drf-extensions#290. (Alternatively, one could remove the p, q, dp, dq, and qi params, but there is an unknown performance cost to doing so as we are not currently caching these keys, and the precompution happens on every load due to the way pyjwkest's API works.)