Update management command for creating jwks #32377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumarkhan999
changed the base branch from
master
to
umar/replace-jwkest-with-pyjwt
mumarkhan999
force-pushed
the
umar/update-management-command-for-creating-jwks
branch
2 times, most recently
from
599b6ec to
409e056
Compare
mumarkhan999
force-pushed
the
umar/update-management-command-for-creating-jwks
branch
from
409e056 to
592ce3b
Compare
mumarkhan999
changed the title
timmc-edx
approved these changes
Jun 14, 2023
Comment on lines
126
to
129
| algo = get_default_algorithms()['RS512'] | ||
| pem = rsa_key.export_key('PEM').decode() | ||
| rsa_jwk = json.loads(algo.to_jwk(algo.prepare_key(pem))) | ||
| public_rsa_jwk = json.loads(algo.to_jwk(algo.prepare_key(pem).public_key())) |
There was a problem hiding this comment.
Suggestion on tightening up this code a little:
Suggested change
| algo = get_default_algorithms()['RS512'] | |
| pem = rsa_key.export_key('PEM').decode() | |
| rsa_jwk = json.loads(algo.to_jwk(algo.prepare_key(pem))) | |
| public_rsa_jwk = json.loads(algo.to_jwk(algo.prepare_key(pem).public_key())) | |
| algo = get_default_algorithms()['RS512'] | |
| key_data = algo.prepare_key(rsa_key.export_key('PEM').decode()) | |
| rsa_jwk = json.loads(algo.to_jwk(key_data)) | |
| public_rsa_jwk = json.loads(algo.to_jwk(key_data.public_key())) |
feat: removing pyjwkest Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master` Co-authored-by: mumarkhan999 <mumarkhan999@users.noreply.github.com>
mumarkhan999
force-pushed
the
umar/update-management-command-for-creating-jwks
branch
from
679b876 to
a602f10
Compare
mumarkhan999
deleted the
umar/update-management-command-for-creating-jwks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for: #32270