Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name length validation #33501

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

Inferato
Copy link
Contributor

@Inferato Inferato commented Oct 16, 2023

Description

According to the UserProfile limitation for the name field:
name = models.CharField(blank=True, max_length=255, db_index=True)
we need to add the validation for the name length.
A better solution would be to use the separate constant which we could use for both the model field and validation criteria, but considering that the field has been unchanged since Feb 2012 - it was rejected to simplify the fix.

Related: open-release/quince.master

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 16, 2023

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added needs test run Author's first PR to this repository, awaiting test authorization from Axim and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 16, 2023
@mphilbrick211
Copy link

Hi @Inferato! Just flagging that there are a few failing checks. Would you mind taking a look?

@Inferato Inferato force-pushed the lytvynenko/additional_name_check branch from fcc4e41 to 2580085 Compare October 30, 2023 13:08
@mphilbrick211 mphilbrick211 requested a review from a team October 30, 2023 16:52
@mphilbrick211
Copy link

Hi @openedx/2u-aperture! This is ready for review/merge.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 30, 2023
@robrap
Copy link
Contributor

robrap commented Nov 29, 2023

@mphilbrick211: [inform] I am moving this on Contributions board from arch-bom to aperture.

@jsnwesson jsnwesson merged commit 0650b4f into openedx:master Dec 4, 2023
63 checks passed
@openedx-webhooks
Copy link

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants