Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: roles 26 mfe course authoring helper function #33599

Merged
merged 22 commits into from
Oct 31, 2023
Merged

feat: roles 26 mfe course authoring helper function #33599

merged 22 commits into from
Oct 31, 2023

Conversation

julianpalmerio
Copy link
Member

@julianpalmerio julianpalmerio commented Oct 25, 2023 •
edited
Loading

Description

This PR is to a feature branch for the course roles project.

It adds a helper function to get all the permissions of a user for a course, and an API with an endpoint to consume it.

@julianpalmerio julianpalmerio changed the base branch from master to ROLES-2-course_roles_setup October 25, 2023 22:52
hsinkoff
hsinkoff reviewed Oct 26, 2023
View reviewed changes
cms/urls.py Show resolved Hide resolved
lms/urls.py Show resolved Hide resolved
openedx/core/djangoapps/course_roles/helpers.py Outdated Show resolved Hide resolved
openedx/core/djangoapps/course_roles/helpers.py Outdated Show resolved Hide resolved
openedx/core/djangoapps/course_roles/tests/test_helpers.py Show resolved Hide resolved
@hsinkoff hsinkoff force-pushed the ROLES-2-course_roles_setup branch 2 times, most recently from 5992663 to 073e499 Compare October 27, 2023 18:23
@julianpalmerio julianpalmerio changed the base branch from ROLES-2-course_roles_setup to master October 30, 2023 19:23
@julianpalmerio julianpalmerio changed the base branch from master to ROLES-2-course_roles_setup October 30, 2023 19:25
@julianpalmerio julianpalmerio force-pushed the julianpalmerio/ROLES-26-MFE-course_authoring-helper-function branch from bf00c27 to 7ac0bb0 Compare October 30, 2023 19:46
@julianpalmerio
feat: Roles 15 - permission checks back end changes part 1 (#33347)
93ec940 
* test: add test cases for permission list check functions

* test: update tests

* feat: add helper functions to check lists of permissions

* style: improve code style

* feat: add course roles checks in the contentstore app

* feat: add course roles checks in the student app

* feat: add course roles checks in the lms discussion app

* feat: add course roles checks in the lms instructor app

* feat: add course roles checks in the Learning Sequences package

* style: fix code style

* fix: course_permission_check calls

* feat: add validation for AnonymousUser in course permission check helper functions

* fix: disable some pylint warnings

* test: update number of querys asserted in has_course_author_access

* feat: add helper functions to check course or organization permissions

* test: update course_roles tests

* feat: replace course or organization helper functions in auth

* docs: update course_roles docstrings
@julianpalmerio
feat: ROLES-23 Create permissions in db table (#33394)
7264e5a 
* feat: add migration to load permissions in the database

* feat: add Permission enum

* feat: change Permission enum name to CourseRolesPermission

* feat: replace permission constants with the CourseRolesPermission enum

* feat: add unique decorator to permissions enum

* feat: add course_roles_permissions dict with names and descriptions (with i18n)

* docs: add CourseRolesPermission docstring

* style: fix pylint errors

* style: fix pylint errors

* docs: add permissions module docstring
@julianpalmerio
feat: add helper function to get user permissions for a course
6aaffae
@julianpalmerio
test: add test for get_all_user_permissions_for_a_course
a2ad052
@julianpalmerio
feat: add views to coures roles api
4590ba2
@julianpalmerio
test: add test for course roles views
8f295d4
@julianpalmerio
feat: add urls for course roles api
85fd714
@julianpalmerio
feat: add course roles api urls to lms and cms
9804f52
@julianpalmerio
docs: add comment to indicate which urls are from course roles api
aec5fad
@julianpalmerio
feat: add translation to ValueError exception message
90ba71b
@julianpalmerio
feat: add translation to ValueError exception message
405fe65
@julianpalmerio
feat: raise exeption if course does not exist
4538950
@julianpalmerio
feat: add instance permissions in get_all_user_permissions_for_a_cour…
5259cd3 
…se helper
@julianpalmerio
feat: improve validations in get_all_user_permissions_for_a_course
4f02a6f
@julianpalmerio
feat: improve validations in UserPermissionsView
7dd6628
@julianpalmerio
test: update get user permissions tests
07c497f
@julianpalmerio
docs: update UserPermissionsView docstring
f4bcc22
@julianpalmerio julianpalmerio force-pushed the julianpalmerio/ROLES-26-MFE-course_authoring-helper-function branch from 7ac0bb0 to f4bcc22 Compare October 30, 2023 19:51
@julianpalmerio julianpalmerio marked this pull request as ready for review October 31, 2023 14:10
@julianpalmerio julianpalmerio merged commit 8dba093 into ROLES-2-course_roles_setup Oct 31, 2023
@julianpalmerio julianpalmerio deleted the julianpalmerio/ROLES-26-MFE-course_authoring-helper-function branch October 31, 2023 14:30
hsinkoff pushed a commit that referenced this pull request Nov 1, 2023
@julianpalmerio @hsinkoff
feat: course_roles mfe-course authoring helper function (#33599)
cfab100 
* feat: Roles 15 - permission checks back end changes part 1 (#33347)

* test: add test cases for permission list check functions

* test: update tests

* feat: add helper functions to check lists of permissions

* style: improve code style

* feat: add course roles checks in the contentstore app

* feat: add course roles checks in the student app

* feat: add course roles checks in the lms discussion app

* feat: add course roles checks in the lms instructor app

* feat: add course roles checks in the Learning Sequences package

* style: fix code style

* fix: course_permission_check calls

* feat: add validation for AnonymousUser in course permission check helper functions

* fix: disable some pylint warnings

* test: update number of querys asserted in has_course_author_access

* feat: add helper functions to check course or organization permissions

* test: update course_roles tests

* feat: replace course or organization helper functions in auth

* docs: update course_roles docstrings

* feat: ROLES-23 Create permissions in db table (#33394)

* feat: add migration to load permissions in the database

* feat: add Permission enum

* feat: change Permission enum name to CourseRolesPermission

* feat: replace permission constants with the CourseRolesPermission enum

* feat: add unique decorator to permissions enum

* feat: add course_roles_permissions dict with names and descriptions (with i18n)

* docs: add CourseRolesPermission docstring

* style: fix pylint errors

* style: fix pylint errors

* docs: add permissions module docstring

* feat: add helper function to get user permissions for a course

* test: add test for get_all_user_permissions_for_a_course

* feat: add views to coures roles api

* test: add test for course roles views

* feat: add urls for course roles api

* feat: add course roles api urls to lms and cms

* docs: add comment to indicate which urls are from course roles api

* feat: add translation to ValueError exception message

* feat: add translation to ValueError exception message

* feat: raise exeption if course does not exist

* feat: add instance permissions in get_all_user_permissions_for_a_course helper

* feat: improve validations in get_all_user_permissions_for_a_course

* feat: improve validations in UserPermissionsView

* test: update get user permissions tests

* docs: update UserPermissionsView docstring

* feat: change message errors

* docs: update docstrings in test_views

* fix: add missing super method call in a class

* fix: add password to test user

* fix: chain re-raising exceptions
hsinkoff pushed a commit that referenced this pull request Nov 8, 2023
@julianpalmerio @hsinkoff
feat: course_roles mfe-course authoring helper function (#33599)
4ac95de 
* feat: Roles 15 - permission checks back end changes part 1 (#33347)

* test: add test cases for permission list check functions

* test: update tests

* feat: add helper functions to check lists of permissions

* style: improve code style

* feat: add course roles checks in the contentstore app

* feat: add course roles checks in the student app

* feat: add course roles checks in the lms discussion app

* feat: add course roles checks in the lms instructor app

* feat: add course roles checks in the Learning Sequences package

* style: fix code style

* fix: course_permission_check calls

* feat: add validation for AnonymousUser in course permission check helper functions

* fix: disable some pylint warnings

* test: update number of querys asserted in has_course_author_access

* feat: add helper functions to check course or organization permissions

* test: update course_roles tests

* feat: replace course or organization helper functions in auth

* docs: update course_roles docstrings

* feat: ROLES-23 Create permissions in db table (#33394)

* feat: add migration to load permissions in the database

* feat: add Permission enum

* feat: change Permission enum name to CourseRolesPermission

* feat: replace permission constants with the CourseRolesPermission enum

* feat: add unique decorator to permissions enum

* feat: add course_roles_permissions dict with names and descriptions (with i18n)

* docs: add CourseRolesPermission docstring

* style: fix pylint errors

* style: fix pylint errors

* docs: add permissions module docstring

* feat: add helper function to get user permissions for a course

* test: add test for get_all_user_permissions_for_a_course

* feat: add views to coures roles api

* test: add test for course roles views

* feat: add urls for course roles api

* feat: add course roles api urls to lms and cms

* docs: add comment to indicate which urls are from course roles api

* feat: add translation to ValueError exception message

* feat: add translation to ValueError exception message

* feat: raise exeption if course does not exist

* feat: add instance permissions in get_all_user_permissions_for_a_course helper

* feat: improve validations in get_all_user_permissions_for_a_course

* feat: improve validations in UserPermissionsView

* test: update get user permissions tests

* docs: update UserPermissionsView docstring

* feat: change message errors

* docs: update docstrings in test_views

* fix: add missing super method call in a class

* fix: add password to test user

* fix: chain re-raising exceptions
hsinkoff pushed a commit that referenced this pull request Nov 16, 2023
@julianpalmerio @hsinkoff
feat: course_roles mfe-course authoring helper function (#33599)
668510e 
* feat: Roles 15 - permission checks back end changes part 1 (#33347)

* test: add test cases for permission list check functions

* test: update tests

* feat: add helper functions to check lists of permissions

* style: improve code style

* feat: add course roles checks in the contentstore app

* feat: add course roles checks in the student app

* feat: add course roles checks in the lms discussion app

* feat: add course roles checks in the lms instructor app

* feat: add course roles checks in the Learning Sequences package

* style: fix code style

* fix: course_permission_check calls

* feat: add validation for AnonymousUser in course permission check helper functions

* fix: disable some pylint warnings

* test: update number of querys asserted in has_course_author_access

* feat: add helper functions to check course or organization permissions

* test: update course_roles tests

* feat: replace course or organization helper functions in auth

* docs: update course_roles docstrings

* feat: ROLES-23 Create permissions in db table (#33394)

* feat: add migration to load permissions in the database

* feat: add Permission enum

* feat: change Permission enum name to CourseRolesPermission

* feat: replace permission constants with the CourseRolesPermission enum

* feat: add unique decorator to permissions enum

* feat: add course_roles_permissions dict with names and descriptions (with i18n)

* docs: add CourseRolesPermission docstring

* style: fix pylint errors

* style: fix pylint errors

* docs: add permissions module docstring

* feat: add helper function to get user permissions for a course

* test: add test for get_all_user_permissions_for_a_course

* feat: add views to coures roles api

* test: add test for course roles views

* feat: add urls for course roles api

* feat: add course roles api urls to lms and cms

* docs: add comment to indicate which urls are from course roles api

* feat: add translation to ValueError exception message

* feat: add translation to ValueError exception message

* feat: raise exeption if course does not exist

* feat: add instance permissions in get_all_user_permissions_for_a_course helper

* feat: improve validations in get_all_user_permissions_for_a_course

* feat: improve validations in UserPermissionsView

* test: update get user permissions tests

* docs: update UserPermissionsView docstring

* feat: change message errors

* docs: update docstrings in test_views

* fix: add missing super method call in a class

* fix: add password to test user

* fix: chain re-raising exceptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsinkoff hsinkoff hsinkoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianpalmerio @hsinkoff