Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove legacy-ip code and Waffle switch #33735

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Conversation

timmc-edx
Copy link
Contributor

@timmc-edx timmc-edx commented Nov 16, 2023

This switch has been kept disabled in edx.org for well over a year with no trouble.

DEPR issue: #33733

  • Wait until 2023-12-01 (DEPR discussion deadline)
  • Announce in Redwood release notes. If any deployer has had ip.legacy enabled, they'll need to be sure to set CLOSEST_CLIENT_IP_FROM_HEADERS before upgrading. This was already communicated in Nutmeg but a reminder will be important.

This switch has been kept disabled in edx.org for well over a year with no
trouble.

DEPR issue: #33733
@timmc-edx timmc-edx marked this pull request as ready for review December 1, 2023 14:19
Copy link
Contributor

@rgraber rgraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmc-edx timmc-edx merged commit 9444186 into master Dec 1, 2023
64 checks passed
@timmc-edx timmc-edx deleted the timmc/legacy-ip branch December 1, 2023 14:45
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants