-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Tag count in components [FC-0036] #33928
feat: Tag count in components [FC-0036] #33928
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@ChrisChV Do you think you could update this PR so that it uses No need to include a version bump, as long as the PRs work together and the counts will be correct once both PRs are merged. |
@bradenmacdonald I have used the python API, not the REST API. I need the change in the function
But I can wait until your PR is ready to bump the version here Edit: Same for outline page Edit 2: Updated in 2f99115 |
requirements/edx/base.txt
Outdated
@@ -779,7 +779,7 @@ openedx-filters==1.6.0 | |||
# via | |||
# -r requirements/edx/kernel.in | |||
# lti-consumer-xblock | |||
openedx-learning==0.3.6 | |||
openedx-learning @ git+https://github.com/open-craft/openedx-learning.git@braden/count-implicit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: bump version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisChV Overall code looks good, and works as expected, except however I found an issue with double counting implicit tags.
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
feat: Tag count in components on Studio Unit page(openedx#33928)
Description
This adds the tag count button on components:
Supporting information
Testing instructions
contentstore.enable_copy_paste_units
andnew_studio_mfe.use_tagging_taxonomy_list_page
flags.new_studio_mfe.use_tagging_taxonomy_list_page
flag.Other information