fix: gender field in create_user_gdpr_testing script

[jerryankur]

Description

In the create_user_gdpr_testing script, the gender property of the UserProfile was set to 'gdpr test gender', which is more than max_length=6 defined in User Model.

#34142

This PR fixes the issue to assign the correct choice 'o' (out of 'f', 'm', 'o').

[openedx-webhooks]

Thanks for the pull request, @jerryankur! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[jerryankur]

hi @pomegranited , can you review this as well.

[pomegranited]

Hi @jerryankur , I am not sure when I'll be able to review this.. Other core contributors might be able to get to it sooner?

[pomegranited]

Hi @jerryankur , thank you for this fix! It gets around the first error thrown by this management command, but then there is another error.

./manage.py lms create_user_gdpr_testing
# django.core.exceptions.FieldError: Cannot resolve keyword 'catalog' into field.

Could you please fix the rest of these errors, and add a test that validates that this management command runs and creates the expected data? Examples of management command tests in the platform can be found here:

• https://github.com/openedx/edx-platform/tree/master/openedx/core/djangoapps/oauth_dispatch/management/commands/tests/
• https://github.com/openedx/edx-platform/tree/master/lms/djangoapps/program_enrollments/management/commands/tests/

[pomegranited]

Nudge @jerryankur 😃

[justinhynes]

Updated status to waiting on author. Once the requests from @pomegranited are taken care of, we can also try and fast track this for review on our side too.

[pomegranited]

Thanks @justinhynes!

Do you know if this create_user_gdpr_testing management command is even used anymore? It seems unlikely given all the errors it throws, so maybe it's better to remove it than to spend time fixing it?

[jerryankur]

@pomegranited thanks for your feedback. i will have a look on it. i was unavailable for a week.

[pomegranited]

No worries at all @jerryankur. It's part of my job to check in here, so I do it :) But it's ok if you don't have time to respond; we can pick up again whenever you do. Thank you for your time!

[justinhynes]

Thanks @justinhynes!

Do you know if this create_user_gdpr_testing management command is even used anymore? It seems unlikely given all the errors it throws, so maybe it's better to remove it than to spend time fixing it?

Unfortunately, I don't. Our team only recently has picked up maintainer duties for the user_api, and I'm not very familiar with this functionality. If fixing this results in too much time spinning wheels, I think it is totally sane to create a public issue (and deferring the fix for this management command) and/or moving towards deprecation/removal.

[obscherler]

Do you know if this create_user_gdpr_testing management command is even used anymore? It seems unlikely given all the errors it throws, so maybe it's better to remove it than to spend time fixing it?

I don’t know. Do you think GDPR compliant is something unimportant for Open edX to be? Do you think the user retirement pipeline is so well documented and so trivial to set up that it doesn’t need testing?

I’ve spent the week trying to set up retirement. The Tutor plugin has out of order steps which cause the LMS to return Bad Request errors with no explanation, it has irrelevant steps, the ecommerce is missing the user retirement API endpoint, and the LMS is missing the retire_mailings endpoint. I’ve already exhausted 21 GDPR test users, very glad I didn’t have to register those manually and only had to fix the create_user_gdpr_testing command (which involved changing the gender to o like @jerryankur did, removing the aforementioned catalog property, and for me, changing the course it enrols the test user into.)

[pomegranited]

@obscherler

Do you think GDPR compliant is something unimportant for Open edX to be?

No, I think it's important for Open edX to continue with its GDPR compliance efforts.

Do you think the user retirement pipeline is so well documented and so trivial to set up that it doesn’t need testing?

I wish this were the case, but no.. retirement pipeline isn't easy to set up, and I don't know how accurate the docs are anymore.

But glad to hear this management command was useful for your testing, so we should keep it :)

Do you want to submit your fixes to a new PR, and we can close this one?

[obscherler]

I’ll try doing that in the next few days.

I’ve finally managed to get the pipeline to run with the services we use, except for ecommerce, where I can’t find a trace of the /api/v2/user/retire endpoint. Where would be the best place to discuss that? The ecommerce repo doesn’t have issues, and is being deprecated (however I don’t know the timeline,) the tubular repo doesn’t accept bug reports, and is being deprecated as well. Should I try in edx-platform, where the retirement scripts are being moved? Thanks.

[deborahgu]

Just marking as changes requested in the comment here by @pomegranited,

[deborahgu]

I’ve finally managed to get the pipeline to run with the services we use, except for ecommerce, where I can’t find a trace of the /api/v2/user/retire endpoint. Where would be the best place to discuss that? The ecommerce repo doesn’t have issues, and is being deprecated (however I don’t know the timeline,) the tubular repo doesn’t accept bug reports, and is being deprecated as well. Should I try in edx-platform, where the retirement scripts are being moved? Thanks.

@obscherler, I'd suggest asking on slack, since this seems more like a request for assistance getting the pipeline running than a clearly defined bug report.

[pomegranited]

@obscherler

I’ll try doing that in the next few days.

Thank you, and no rush. :)

I’ve finally managed to get the pipeline to run with the services we use, except for ecommerce, where I can’t find a trace of the /api/v2/user/retire endpoint. Where would be the best place to discuss that?

Does this comment on extensions.api.v2.retirement.EcommerceIdView provide any clues? Otherwise I agree with @deborahgu , best to ask on Slack.

Specifically this is used to retire users identified by "ecommerce-{id}" from Segment.

edX uses Segment for a lot of things, but I don't think much of this made it out to the community. The tubular script references this endpoint too, so maybe this script's reference to /api/v2/user/retire never actually worked?

But ya, the edx-platform migration for these scripts is probably the best place to ask questions, e.g on this Slack thread.

[pomegranited]

Hi @jerryankur and @obscherler , it's been a while since there's been any action on this PR, so I'm going to close it out.
But feel free to open a new one and ping me if you get time to work on this.

[openedx-webhooks]

@jerryankur Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.