-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support to Group Configuration view for Teams partitions #34643
Conversation
Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
7fe3838
to
c32514d
Compare
c32514d
to
dcdad95
Compare
@mariajgrimaldi is this part of the testing instructions necessary? Since the entrypoint is already in master and the nighly image should contain this already I would expect that the entrypoint is already isntalled by the time I switch branches, isn't it? |
@felipemontoya: yes, not needed. I copy pasted the instructions from the other PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR looks good to me. Moving the partition to read only makes them show nicely in the UI and the list of places where the partition is used is correct.
Sandbox deployment failed 💥 |
@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR adds support for viewing Content Groups associated with teams in Studio's Group Configurations view. Before this change, after turning the content groups + teams connection on, the view didn't render correctly:
Screencast.from.26-04-24.12.12.57.mp4
Although partitions and their groups were displayed, the frontend implementation only supported one partition per scheme. This PR supports multiple partitions per scheme by using the partition ID:
Also, it modifies the team partition scheme to be read-only, so the user doesn't modify it since partitions are created dynamically.
Supporting information
Following up: #33788
Testing instructions
Testing instructions
After creating your course, you'll need to turn on a course-level flag that enables content groups for teams:
Go to /admin/waffle_utils/waffleflagcourseoverridemodel
Add new flag using your new course ID: teams.content_groups_for_teams
Enable teams for the course: Studio > Select course > Content > Pages & resources > Teams > Teams toggle
Create a few team sets (or groups) from the Course Authoring MFE for your course:
Then, go to the LMS and create a few teams within those team-set (or topics, or groups):
Go to the Group Configurations view in Studio for the course you just configured.
Deadline
This effort is part of the Spanish consortium project, so it'd be ideal to merge this before the end of the project.
Other information
More technical info on teams: https://openedx.atlassian.net/wiki/spaces/AC/pages/160611195
Course author docs on teams: https://edx.readthedocs.io/projects/edx-partner-course-staff/en/latest/course_features/teams/teams_setup.html#teams-overview
PR Sandbox
Settings