-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Copy tags when sync library [FC-0062] #35596
feat: Copy tags when sync library [FC-0062] #35596
Conversation
Thanks for the pull request, @ChrisChV! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisChV Nice job! 🚀
- I tested this: (Played around with tags in library and course via library component and verified the tags after sync.)
- I read through the code
- I checked for accessibility issues
- Includes documentation
openedx/core/djangoapps/content_tagging/rest_api/v1/serializers.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/content_tagging/rest_api/v1/serializers.py
Outdated
Show resolved
Hide resolved
openedx/core/djangoapps/content_tagging/rest_api/v1/serializers.py
Outdated
Show resolved
Hide resolved
@ChrisChV I guess this has needed some refactoring since I last reviewed it, so let me know when it's ready for another review. |
9fe57ef
to
4418951
Compare
@bradenmacdonald Yes, the way to copy components has changed. It's ready for a new review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion... otherwise I'm just testing now and then I'll approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it works great! The only weird thing is that since tags aren't part of the draft-publish cycle, you have to make changes to the block and publish them before the tags will be synced. We should mention that to the product team during acceptance testing.
Please consider making the changes I suggested before merging, but go ahead and merge either way.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
This PR adds:
copy_tags
function of tagging API to copy tags from all library components when adding (copy) a library in a course.ObjectTagMinimalSerializer
to avoid delete tags that are copied.Supporting information
Testing instructions
make requirements
in lms and cms shell or rebuild your openedx-dev image in tutor.Deadline
ASAP
Other information
Before merge:
openedx-learning
version: feat: Copy object tags [FC-0062] openedx-learning#236