Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dockerfile setup #35731

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Conversation

huniafatima-arbi
Copy link
Contributor

@huniafatima-arbi huniafatima-arbi commented Oct 25, 2024

Description

This PR removes files for image creation and publish. It removes the following files

  1. Dockerfile
  2. .dockerignore
  3. .github/workflows/docker-publish.yml

Issue link

edx/public-dockerfiles#3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can be removed as well I believe.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to merge, let me know if you'd like me to merge it, otherwise feel free to merge when you're ready.

@UsamaSadiq UsamaSadiq merged commit 829f6db into master Jan 16, 2025
49 checks passed
@UsamaSadiq UsamaSadiq deleted the huniafatima/remove-dockerfile-setup branch January 16, 2025 12:47
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants