Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Drop some stub code. #36102

Merged
merged 1 commit into from
Jan 15, 2025
Merged

test: Drop some stub code. #36102

merged 1 commit into from
Jan 15, 2025

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Jan 13, 2025

I believe this was only used with BokChoy and just got missed in the
various cleanup. Removing it now since we're not using it.

I believe this was only used with BokChoy and just got missed in the
various cleanup.  Removing it now since we're not using it.
@feanil feanil marked this pull request as ready for review January 13, 2025 20:20
@e0d
Copy link
Contributor

e0d commented Jan 13, 2025

@angonz FYI.

@feanil feanil requested a review from a team January 13, 2025 21:48
@feanil feanil changed the title test: Drop some stub config. test: Drop some stub code. Jan 13, 2025
Copy link
Contributor

@ormsbee ormsbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@feanil feanil merged commit fa0ead4 into master Jan 15, 2025
50 checks passed
@feanil feanil deleted the feanil/remove_stubs branch January 15, 2025 15:33
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@robrap
Copy link
Contributor

robrap commented Jan 16, 2025

@feanil: Thanks for the clean-up. Please see these search results: https://github.com/search?q=repo%3Aopenedx%2Fedx-platform%20common%2Fdjangoapps%2Fterrain&type=code. Thanks!

feanil added a commit that referenced this pull request Jan 17, 2025
The terrain app and its stub servers were removed as a part of
#36102 but these last few
things got missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants