Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds sorting and search functionality #1379

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Jan 11, 2025

Description

Adds sorting and search functionality to the enterprise members table and displays the learner's full name instead of username.

https://2u-internal.atlassian.net/browse/ENT-9861

Testing Instructions

Screen.Recording.2025-01-14.at.10.11.00.AM.mov

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 marked this pull request as ready for review January 11, 2025 00:41
@katrinan029 katrinan029 requested a review from a team January 11, 2025 00:42
Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (482781d) to head (0dcd31e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1379   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         624      624           
  Lines       13635    13641    +6     
  Branches     2850     2816   -34     
=======================================
+ Hits        11703    11709    +6     
  Misses       1862     1862           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 force-pushed the knguyen/ent-9861 branch 3 times, most recently from 6fa63cb to 3428c00 Compare January 14, 2025 19:41
@katrinan029 katrinan029 merged commit 8666c65 into master Jan 15, 2025
4 checks passed
@katrinan029 katrinan029 deleted the knguyen/ent-9861 branch January 15, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants