-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enabling the ability to log in with a username consisting of 2 characters (backport from palm branch) #1073
fix: Enabling the ability to log in with a username consisting of 2 characters (backport from palm branch) #1073
Conversation
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1073 +/- ##
=======================================
Coverage 87.47% 87.47%
=======================================
Files 124 124
Lines 2251 2251
Branches 629 629
=======================================
Hits 1969 1969
Misses 273 273
Partials 9 9 ☔ View full report in Codecov by Sentry. |
@mphilbrick211 I will have someone from the team pick this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
@Lunyachek Can you please rebase your branch with the latest code? |
@Lunyachek - flagging this for you! |
d643a83
to
7c67ed6
Compare
Sorry for the delay. Rebased! |
Hi @attiyaIshaque! Are you able to merge this for us? |
7c67ed6
to
e664b9e
Compare
@Lunyachek Can you please rebase your branch with the latest code? I have missed your notification.Thanks |
Done |
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This is backport from this PR - #1072
Description
For now, we have the ability to register with a username consisting of 2 characters. However, when we try to log in with this username, we receive an error indicating that the 'username should be at least 3 characters.' In this PR, we fix this bug.
Before
2023-10-11.17.32.42.mov
2023-10-11.17.40.09.mov
After
2023-10-11.17.41.42.mov