Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enabling the ability to log in with a username consisting of 2 characters (backport from palm branch) #1073

Conversation

Lunyachek
Copy link
Contributor

This is backport from this PR - #1072

Description

For now, we have the ability to register with a username consisting of 2 characters. However, when we try to log in with this username, we receive an error indicating that the 'username should be at least 3 characters.' In this PR, we fix this bug.

Before

2023-10-11.17.32.42.mov
2023-10-11.17.40.09.mov

After

2023-10-11.17.41.42.mov

@Lunyachek Lunyachek requested a review from a team as a code owner October 11, 2023 16:38
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 11, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 11, 2023

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3d9638) 87.47% compared to head (8ac3cfe) 87.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1073   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files         124      124           
  Lines        2251     2251           
  Branches      629      629           
=======================================
  Hits         1969     1969           
  Misses        273      273           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Oct 11, 2023
@mphilbrick211
Copy link

Hi @openedx/vanguards! Would someone be able to review/ merge this along with the backports #1072 and #1098 ? Thanks!

@zainab-amir
Copy link
Contributor

@mphilbrick211 I will have someone from the team pick this.

Copy link
Contributor

@attiyaIshaque attiyaIshaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@attiyaIshaque
Copy link
Contributor

@Lunyachek Can you please rebase your branch with the latest code?

@mphilbrick211
Copy link

@Lunyachek - flagging this for you!

@Lunyachek Lunyachek force-pushed the lunyachek/fix/login-two-characters-username-master branch from d643a83 to 7c67ed6 Compare January 19, 2024 13:35
@Lunyachek
Copy link
Contributor Author

attiyaIshaque

Sorry for the delay. Rebased!

@mphilbrick211
Copy link

Hi @attiyaIshaque! Are you able to merge this for us?

@Lunyachek Lunyachek force-pushed the lunyachek/fix/login-two-characters-username-master branch from 7c67ed6 to e664b9e Compare January 24, 2024 22:25
@attiyaIshaque
Copy link
Contributor

attiyaIshaque commented Feb 13, 2024

@Lunyachek Can you please rebase your branch with the latest code? I have missed your notification.Thanks

@Lunyachek
Copy link
Contributor Author

@Lunyachek Can you please rebase your branch with the latest code? I have missed your notification.Thanks

Done

@attiyaIshaque attiyaIshaque merged commit e9aaf70 into openedx:master Feb 15, 2024
7 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Lunyachek Lunyachek deleted the lunyachek/fix/login-two-characters-username-master branch February 15, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants